Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Synced Lyrics #555

Open
Suyashtnt opened this issue Mar 22, 2024 · 4 comments
Open

Word Synced Lyrics #555

Suyashtnt opened this issue Mar 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Suyashtnt
Copy link

What do you want to be added?

Some LRC files have support for word-synced lyrics in the following format:

[line length]  <Word time> word <Time between words>   <Word time> OtherWord

e.g.

[00:18.55] <00:18.55> I've <00:20.25>   <00:20.28> been <00:20.36>   <00:20.39> painting <00:20.77>   <00:20.80> every <00:21.04>   <00:21.11> fence <00:21.45>   <00:21.49> I <00:21.56>   <00:21.65> know 

It would be neat to have this supported in feishin. Right now they look like this:
image

Additional context

Not sure if this should rather be handled by the servers directly (see navidrome/navidrome#2920)

@Suyashtnt Suyashtnt added the enhancement New feature or request label Mar 22, 2024
@iiPythonx
Copy link
Contributor

I believe this would have to be handled by Navidrome as Feishin just shows whatever Navidrome responds with (and based on the screenshot Navidrome obviously isn't parsing your LRC as proper lyrics).

@Suyashtnt
Copy link
Author

I believe this would have to be handled by Navidrome as Feishin just shows whatever Navidrome responds with (and based on the screenshot Navidrome obviously isn't parsing your LRC as proper lyrics).

navidrome basically sends a lyric json/xml file with each line having its own field. it would require updating that whole format for word-by-word support which may be an issue, which is why I also sent a request here

@kgarner7
Copy link
Collaborator

Strictly speaking, there's no need for Navidrome (or other Subsonic servers) to output anything more than a line, the word-based processing can be done in Feishin itself.

@Suyashtnt
Copy link
Author

Strictly speaking, there's no need for Navidrome (or other Subsonic servers) to output anything more than a line, the word-based processing can be done in Feishin itself.

which is why I asked here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants