Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"$ git init; ti init; ti" firing bugs with any command, no error-handling with null -repo #62

Closed
heoa opened this issue Jun 30, 2012 · 3 comments

Comments

@heoa
Copy link

heoa commented Jun 30, 2012

Tested on 12.04 Ubuntu. It seems to lack error handling with Null -repo.

$ cat /proc/version
Linux version 3.2.0-26-generic (buildd@batsu) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #41-Ubuntu SMP Thu Jun 14 17:49:24 UTC 2012

$ ti new -t 'testing1'
/var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:700:in command': git branch "-a" 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError) from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:672:incommand_lines'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:200:in branches_all' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/branches.rb:12:ininitialize'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:in new' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:inbranches'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:414:in which_branch?' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:32:ininitialize'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:in new' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:inopen'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:34:in initialize' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:innew'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:in parse' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:9:inexecute'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/bin/ti:13
from /usr/local/bin/ti:19:in load' from /usr/local/bin/ti:19 xyz@xyz:~/T$ ti new --help /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:700:incommand': git branch "-a" 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError)
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:672:in command_lines' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:200:inbranches_all'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/branches.rb:12:in initialize' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:innew'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:in branches' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:414:inwhich_branch?'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:32:in initialize' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:innew'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:in open' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:34:ininitialize'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:in new' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:inparse'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:9:in execute' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/bin/ti:13 from /usr/local/bin/ti:19:inload'
from /usr/local/bin/ti:19
xyz@xyz:/T$ ti --help
/var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:700:in command': git branch "-a" 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError) from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:672:incommand_lines'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:200:in branches_all' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/branches.rb:12:ininitialize'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:in new' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:inbranches'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:414:in which_branch?' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:32:ininitialize'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:in new' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:inopen'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:34:in initialize' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:innew'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:in parse' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:9:inexecute'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/bin/ti:13
from /usr/local/bin/ti:19:in load' from /usr/local/bin/ti:19 xyz@xyz:~/T$ ti --help /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:700:incommand': git branch "-a" 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError)
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:672:in command_lines' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:200:inbranches_all'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/branches.rb:12:in initialize' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:innew'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:in branches' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:414:inwhich_branch?'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:32:in initialize' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:innew'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:in open' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:34:ininitialize'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:in new' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:inparse'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:9:in execute' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/bin/ti:13 from /usr/local/bin/ti:19:inload'
from /usr/local/bin/ti:19
xyz@xyz:
/T$ ti
/var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:700:in command': git branch "-a" 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError) from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:672:incommand_lines'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/lib.rb:200:in branches_all' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/branches.rb:12:ininitialize'
from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:in new' from /var/lib/gems/1.8/gems/git-1.2.5/lib/git/base.rb:180:inbranches'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:414:in which_branch?' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/base.rb:32:ininitialize'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:in new' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng.rb:50:inopen'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:34:in initialize' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:innew'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:14:in parse' from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/lib/ticgit-ng/cli.rb:9:inexecute'
from /var/lib/gems/1.8/gems/TicGit-ng-1.0.2.14/bin/ti:13
from /usr/local/bin/ti:19:in `load'
from /usr/local/bin/ti:19

@jeffWelling
Copy link
Owner

This has been dealt with in the latest version, though it does seem like an edge case. Please update your gem and check that this issue is resolved for you.

The issue that I fixed for this (it wasn't 100% clear to me what your problem was) was that TicGit-ng didn't check for and gracefully fail when someone tried to use TicGit-ng with a repository that did not have any commits in it yet. To resolve this, I added error checking for this condition and an rspec spec to prevent regression, so if I understood your problem correctly then hopefully this is resolved.

Let me know, in the meantime I will mark this issue as closed.

@heoa
Copy link
Author

heoa commented Aug 21, 2012

I am using now Debian and some errors, not sure whether I am running the newest ticgit.

$ cat /proc/version
Linux version 3.2.0-0.bpo.2-686-pae (Debian 3.2.20-1~bpo60+1) (debian-kernel@lists.debian.org) (gcc version 4.4.5 (Debian 4.4.5-8) ) #1 SMP Sat Jun 30 08:29:17 UTC 2012
$ git init
$ ti init
/usr/lib/ruby/1.8/git/lib.rb:643:in command': git branch -a 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError) from /usr/lib/ruby/1.8/git/lib.rb:615:incommand_lines'
from /usr/lib/ruby/1.8/git/lib.rb:209:in branches_all' from /usr/lib/ruby/1.8/ticgit/base.rb:241:inload_tickets'
from /usr/lib/ruby/1.8/ticgit/base.rb:72:in reset_ticgit' from /usr/lib/ruby/1.8/ticgit/base.rb:38:ininitialize'
from /usr/lib/ruby/1.8/ticgit.rb:25:in new' from /usr/lib/ruby/1.8/ticgit.rb:25:inopen'
from /usr/lib/ruby/1.8/ticgit/cli.rb:23:in initialize' from /usr/lib/ruby/1.8/ticgit/cli.rb:16:innew'
from /usr/lib/ruby/1.8/ticgit/cli.rb:16:in parse' from /usr/lib/ruby/1.8/ticgit/cli.rb:12:inexecute'
from /usr/bin/ti:10
$ ti
/usr/lib/ruby/1.8/git/lib.rb:643:in command': git branch -a 2>&1:fatal: Failed to resolve HEAD as a valid ref. (Git::GitExecuteError) from /usr/lib/ruby/1.8/git/lib.rb:615:incommand_lines'
from /usr/lib/ruby/1.8/git/lib.rb:209:in branches_all' from /usr/lib/ruby/1.8/ticgit/base.rb:241:inload_tickets'
from /usr/lib/ruby/1.8/ticgit/base.rb:72:in reset_ticgit' from /usr/lib/ruby/1.8/ticgit/base.rb:38:ininitialize'
from /usr/lib/ruby/1.8/ticgit.rb:25:in new' from /usr/lib/ruby/1.8/ticgit.rb:25:inopen'
from /usr/lib/ruby/1.8/ticgit/cli.rb:23:in initialize' from /usr/lib/ruby/1.8/ticgit/cli.rb:16:innew'
from /usr/lib/ruby/1.8/ticgit/cli.rb:16:in parse' from /usr/lib/ruby/1.8/ticgit/cli.rb:12:inexecute'
from /usr/bin/ti:10
$ dpkg -l ticgit
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Description
+++-==========================-==========================-====================================================================
ii ticgit 0.3.3-2 ticketing system built on Git

@jeffWelling
Copy link
Owner

  1. That's improper usage for TicGit-ng. The appropriate usage is to first add at least one commit to git, and in the latest version of TicGit-ng there has been code added to make sure that when you try to use TicGit-ng without adding commits to git first that TicGit-ng fails gracefully and explains why it has failed.

  2. It appears you are using TicGit, not TicGit-ng, and should be filing these issues on the TicGit page instead of the TicGit-ng Issues page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants