Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16 #5

Merged
merged 2 commits into from Apr 5, 2019
Merged

Update to React 16 #5

merged 2 commits into from Apr 5, 2019

Conversation

alexvicegrab
Copy link
Contributor

@alexvicegrab alexvicegrab commented Mar 28, 2019

I've updated the necessary components, but I'm uncertain as how to test this works, as I have been unable to make it work by installing my own branch via npm in an existing project:

./src/index.js
Module not found: Can't resolve 'react-awesome-resume' in '/Users/sasha/Projects/curriculum-vitae/cv-react-2/src'

I'd be grateful for some more detailed instructions on how to build/test this properly, so I can do this myself.

Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
Copy link
Contributor Author

Aha, managed to install using local npm install, and everything appears to work fine on my end. Also icon issues fixed.

@jeffwillette jeffwillette merged commit dc0fbab into jeffwillette:master Apr 5, 2019
@jeffwillette
Copy link
Owner

Thanks!

@alexvicegrab alexvicegrab deleted the update branch April 5, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants