Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to detect SQL strict mode and warn the user! #285

Closed
jegelstaff opened this issue Nov 14, 2018 · 2 comments
Closed

We need to detect SQL strict mode and warn the user! #285

jegelstaff opened this issue Nov 14, 2018 · 2 comments

Comments

@jegelstaff
Copy link
Owner

jegelstaff commented Nov 14, 2018

As of MySQL 5.7, MariaDB 10.2.4, Strict mode is the default in MySQL (STRICT_TRANS_TABLES, and some other setting(s) indicate this is on when you query for the modes). We need to check this as part of every admin page load and tell the users, like the DB patch process that comes up automatically. We can try to fix it, but possibly the user doesn't have rights to alter the mode, and it would come back incorrectly on startup most likely, so should always be fixed by a DB admin.

@jegelstaff
Copy link
Owner Author

We can also detect and use INSERT IGNORE and UPDATE IGNORE.

@jegelstaff
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant