Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Merkle Tree has a bug #52

Open
cocos543 opened this issue Nov 15, 2018 · 0 comments
Open

Make Merkle Tree has a bug #52

cocos543 opened this issue Nov 15, 2018 · 0 comments

Comments

@cocos543
Copy link

The problematic code looks like this:

// NewMerkleTree creates a new Merkle tree from a sequence of data
func NewMerkleTree(data [][]byte) *MerkleTree {
	var nodes []MerkleNode

	if len(data)%2 != 0 {
		data = append(data, data[len(data)-1])
	}

	for _, datum := range data {
		node := NewMerkleNode(nil, nil, datum)
		nodes = append(nodes, *node)
	}

	for i := 0; i < len(data)/2; i++ {
		var newLevel []MerkleNode

		for j := 0; j < len(nodes); j += 2 {
			node := NewMerkleNode(&nodes[j], &nodes[j+1], nil)
			newLevel = append(newLevel, *node)
		}

		nodes = newLevel
	}

	mTree := MerkleTree{&nodes[0]}

	return &mTree
}

Because the count of total level 'k' is equal to [k = log2(S + 1)] , S is the number of "Full Binary Tree" nodes.
Such as, When len(Leaf nodes) = 32, so S = 63 , k = log2(63+1) = 6; Now k is 6, not 32/2!

My code show below:

func NewMerkleTree(data [][]byte) *MerkleTree {
	var nodes []MerkleNode

	if len(data)%2 != 0 {
		data = append(data, data[len(data)-1])
	}

	for _, datum := range data {
		mNode := NewMerkleNode(nil, nil, datum)
		nodes = append(nodes, *mNode)
	}

TreeNode:
	for {
		var newLevel []MerkleNode

		for j := 0; j < len(nodes); j += 2 {
			if len(nodes) == 1 {
				break TreeNode
			}
			node := NewMerkleNode(&nodes[j], &nodes[j+1], nil)
			newLevel = append(newLevel, *node)
		}

		nodes = newLevel
	}

	mTree := MerkleTree{&nodes[0]}

	return &mTree

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant