fix: play nice with server-side rendering #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using server-side rendering tools like Gatsby or Next.js, atcb ends up being included in a NodeJS process. It can't assume that `document` is defined in these contexts. This adds a new test which simply requires the file to see if it works. When this test was initially added, the `require` caused errors. These errors have now been fixed. This also adds a GitHub Action to run the test, to make it easier to avoid breaking server-side rendering in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using server-side rendering tools like Gatsby or Next.js, atcb ends up being included in a NodeJS process. It can't assume that
documentis defined in these contexts.This adds a new test which simply requires the file to see if it works. When this test was initially added, the
requirecaused errors. These errors have now been fixed.This also adds a GitHub Action to run the test, to make it easier to avoid breaking server-side rendering in the future.
Types of changes
Checklist: