Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap-sass glyphicons not being brought into assets destination #86

Closed
delputnam opened this issue Jul 4, 2014 · 8 comments
Closed
Labels

Comments

@delputnam
Copy link

When using the built-in support for bootstrap-sass, the javascript and styles are correctly brought into the assets destination directory, but the glyphicons are not copied over. I'm not sure if this is related to issue #85 or not.

@ixti
Copy link
Contributor

ixti commented Jul 4, 2014

That does not related, but needs to be fixed. ;)) Will try to fix it out ASAP.

@ixti ixti self-assigned this Jul 4, 2014
@ixti ixti added the bug label Jul 4, 2014
@delputnam
Copy link
Author

Awesome. Thank you.

@AJ-Acevedo
Copy link

I'm currently working on updating Jekyll KB to the latest version of Jekyll, Bootstrap and jekyll-assets. With that being said I do believe my implementation of Bootstrap font icons will still apply.

Here is my implementation for the JekyllKB project

By adding the referenced SASS code in the link above I can easily update Bootstrap to the latest version without having to modify any additional code.

@lawso017
Copy link

Also running into this issue using 0.11.

@anroots
Copy link
Contributor

anroots commented May 16, 2015

A similar problem occurs with Font Awesome: the CSS file is correctly copied (when //= require-ing it), but the web font files are not. I've soured the web on how to 'correctly' solve this (a lib requires additional files, not only the main js or css), but have found no working solution. Sprockets has a //= provide directive, but this does not work here.

Any ideas, help?

@anroots
Copy link
Contributor

anroots commented May 16, 2015

Update: @AJ-Acevedo's solution worked. Manually referencing to the font files from included CSS did the trick: the font files were copied over into the _site/assets directory.

@rzane
Copy link

rzane commented May 19, 2015

Assuming you're using bootstrap-sass, you just do the following:

@import 'bootstrap-sprockets';
@import 'bootstrap';

This forces bootstrap to use font-path to load fonts, which makes Jekyll assets load the fonts. See: https://github.com/twbs/bootstrap-sass/blob/master/assets/stylesheets/_bootstrap-sprockets.scss

@envygeeks
Copy link
Owner

Closing this then, this is an upstream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants