Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Minima for theme? #4

Closed
pathawks opened this issue Feb 6, 2018 · 4 comments
Closed

Use Minima for theme? #4

pathawks opened this issue Feb 6, 2018 · 4 comments

Comments

@pathawks
Copy link
Member

pathawks commented Feb 6, 2018

If we used Minima as a theme, it might give us a better idea of how a real site would look.

Of course, it would also introduce another variant.

@DirtyF
Copy link
Member

DirtyF commented Feb 6, 2018

I made some tests with minima and applying layouts makes a real diff like +50% build time with a single layout applied. We need benchmarks with layouts.

Could we run benchmarks against a GitHub theme repo?
Could we isolate variants like in a A/B/n testing?

@DirtyF
Copy link
Member

DirtyF commented Feb 6, 2018

Here's a sample benchmark for 1000 posts run with minima, looks like when the date and content doesn't change, generating posts is faster. Should we decrement dates by a day?

Filename                                                              | Count |    Bytes |  Time
----------------------------------------------------------------------+-------+----------+------
_layouts/default.html                                                 |  1001 | 7743.29K | 6.840
usr/local/lib/ruby/gems/2.5.0/gems/minima-2.1.1/_includes/head.html   |  1001 |  629.14K | 3.350
usr/local/lib/ruby/gems/2.5.0/gems/minima-2.1.1/_includes/header.html |  1001 | 1229.74K | 1.644
usr/local/lib/ruby/gems/2.5.0/gems/minima-2.1.1/_includes/footer.html |  1001 |  549.38K | 0.917
_layouts/post.html                                                    |  1000 | 4935.44K | 0.744
_layouts/home.html                                                    |     1 |  208.96K | 0.499
_posts/2018-02-06-test_post_1.md                                      |     1 |    3.94K | 0.279
_posts/2018-02-06-test_post_320.md                                    |     1 |    3.94K | 0.006
_posts/2018-02-06-test_post_608.md                                    |     1 |    3.94K | 0.003
_posts/2018-02-06-test_post_502.md                                    |     1 |    3.94K | 0.001
_posts/2018-02-06-test_post_746.md                                    |     1 |    3.94K | 0.001
_posts/2018-02-06-test_post_3.md                                      |     1 |    3.94K | 0.001
_posts/2018-02-06-test_post_421.md                                    |     1 |    3.94K | 0.001
_posts/2018-02-06-test_post_785.md                                    |     1 |    3.94K | 0.001
...
                    done in 16.374 seconds.

@ashmaroli
Copy link
Member

ashmaroli commented Feb 6, 2018

Should we decrement dates by a day?

Yes, that would be best, because a real site would have posts published on the same day and over multiple days.. So, if there's a performance sink somewhere, we need to be aware of it's existence..

@DirtyF
Copy link
Member

DirtyF commented Feb 6, 2018

fixed by #8

@DirtyF DirtyF closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants