Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all these crazy monkey patches #5

Closed
parkr opened this issue Aug 10, 2014 · 7 comments
Closed

Remove all these crazy monkey patches #5

parkr opened this issue Aug 10, 2014 · 7 comments
Assignees
@parkr
Labels
bug help wanted

Comments

@parkr
Copy link
Member

parkr commented Aug 10, 2014

This repository contains core extensions, which can muck with a lot of stuff.

This "reborn" version should not contain any of these core extensions. Let's figure out a way to use modules & module methods to get it all isolated from the core.
@parkr parkr self-assigned this Aug 10, 2014
@parkr
Copy link
Member Author

parkr commented Aug 13, 2014

String monkey patches now gone. Just Array, Vector, Object, etc left.

@Ch4s3
Copy link
Member

Ch4s3 commented Oct 1, 2014

I might be interested in jumping in on this.

@parkr
Copy link
Member Author

parkr commented Oct 1, 2014

@Ch4s3 Please, jump right in!

@Ch4s3
Copy link
Member

Ch4s3 commented Oct 1, 2014

Great! I just submitted a pull for fixing the Object monkey patch. We love this gem at work, so I hope we can help out.

@Ch4s3
Copy link
Member

Ch4s3 commented Oct 7, 2014

So the fix is in a pull req, any chance of getting that merged soon?

@parkr parkr mentioned this issue Oct 7, 2014
Merged
@parkr
Copy link
Member Author

parkr commented Nov 8, 2014

Just the Vector and Matrix extensions now.

@parkr parkr added the bug label Nov 8, 2014
@Ch4s3
Copy link
Member

Ch4s3 commented Nov 10, 2014

I'm working on Vector, but I'm not sure I can tackle Matrix.

@Ch4s3 Ch4s3 mentioned this issue Dec 3, 2014
Open
@parkr parkr closed this as completed Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parkr parkr

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parkr @Ch4s3