-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images used only with asset_path in sass are not getting included in build. #261
Comments
They should work, as they should be flagged as they should go through our system but I'll double check. |
Hulk: Today |
Unfortunately I am not able to reproduce this, please provide more information, including your build logs. |
Hey @envygeeks thank you so much for looking into this and for adding that test! I may be misunderstanding the test, but could there be a difference between including the image file in css vs using the sass helper function? I created a minimal example site to reproduce the issue here https://github.com/devm33/missing-jekyll-assets-issue In doing so I realized that the steps to reproduce are actually:
So perhaps this an issue with the |
No there couldn't be (well, let me rephrase that as shouldn't,) because they are the exact same helpers using the exact same code (as far as I'm aware.) That said though, I'm happy to fork the source and see what I can find out by shimming it. Thanks for providing some source! |
No problem! Hope that's useful. I've been digging a bit more into this and it's not limited to sass files the same thing also happens to js files that have an asset_path or similar in them. It seems html includes are cached differently (perhaps not cached?) |
We cache all JS and CSS files regardless of whether they have liquid and let upstream bust them but that doesn't affect what happens in processing and it doesn't affect what happens with Liquid AFAIW. I guess we'll find out. |
I've audited my code and found where I think this is happening. It seems that unless we render a tag we don't add it to the used list, I actually discovered this while optimizing for manifests, so this should be fixed today with the release going out. |
It turned out now to be that, yeah I cannot replicate this, no matter what I try. I even verified our tests and it turns out we explicitly test for this behavior in our specs. |
I'm gonna double check this tonight once again before I drop v2.2.1 |
Hi, I've double checked this site by pulling down your source and was again unable to replicate the issue, the JPG was properly written for me. So I'm going to close this for now. If you continue to have the problem please provide more information if you can. This might have been accidentally fixed on master before I realized it too. |
Hi. I’ve just had the exact same problem after reinstalling OS X and moving/relocating both my repository and working copy. The solution that worked for me was to |
Fyi @arron-jeffery I've been using see this script https://github.com/devm33/devm33/blob/master/ln/_local hope that helps 😄 |
I am having the same issue as described: any files referenced only from the SCSS don’t actually generate on |
@rbmntjs please provide a working case (a repository that can be cloned to have my bot test it) and I'll happily test it and see if I can reproduce the problem and reopen this ticket if I can reproduce. Otherwise a "I had this problem too" helps little in solving an unreproducable bug. Thanks! |
I'm new to jekyll & jekyll-assets, and with a fresh project am also experiencing this. |
Hey there,
Please do let me know if I'm doing something wrong here, but it looks like there's an issue with including files when called from the sass helper function asset_path.
Here's an example of what I'm talking about
Then the
vsm_bg.jpg
image is not include in the build_site
directory. Oddly enough in the rendered css file the asset_path is completed with the digested path:My site is on github you can see the full source here https://github.com/devm33/devm33/tree/master/ln
and the line of sass I'm talking about here https://github.com/devm33/devm33/blob/master/ln/_assets/css/main/_landing.scss#L6
Thanks
The text was updated successfully, but these errors were encountered: