Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate summary content #181

Closed
ghost opened this issue Jul 9, 2017 · 7 comments
Closed

Truncate summary content #181

ghost opened this issue Jul 9, 2017 · 7 comments

Comments

@ghost
Copy link

ghost commented Jul 9, 2017

Summary content currently does not truncate text, which can cause a large amount of duplication if feeds without adding a lot of value. I've opened a related issue against core which, if fixed there, will eliminate the need for this issue: jekyll/jekyll#6215

@pathawks
Copy link
Member

pathawks commented Jul 9, 2017

Can you provide more detail?

If a user provides an explicit summary, we should only output part of it??

@ghost
Copy link
Author

ghost commented Jul 9, 2017

Examples are good. Here's an example summary in a feed I have:

<summary type="html">The Imperial Champlains were on of the first major African American street gangs in Chicago.  In 1948 or 1949 the Imperial Champlains formed in between the intersections of 16th Street and Trumbull and 16th and Homan in the North Lawndale neighborhood.  The Champlains were a breakaway group from the Egyptian Cobras that formed in 1948 in the community to deal with racism from angry Jewish youths.  I do not know why some of the Cobras broke away to start the Champlains but I do know that both gangs would grow to become the largest gangs in North Lawndale as they fought each other viciously for control of the neighborhood.  By 1955 more gangs began breaking away from the Champlains and the Cobras causing a major gang war on the streets of North Lawndale which prompted many more members of this mostly Jewish community to leave the neighborhood, the Champlains still continued to grow despite losing members to other gangs, the newer members were Junior Champlains. By 1957 the Chicago police had identified and targeted the Champlains and began arresting several members of many gangs in the neighborhood and the Champlains were the angriest.  Many of the boys were taken to the Illinois Youth Center in St. Charles to serve out sentences.  It was in this facility where Edwin Perry got together with 6 members of the Imperial Champlains to create the Vice Lords.  In 1958 when the Vice Lords hit the streets of North Lawndale they aggressively attempted a complete takeover of the whole North Lawndale neighborhood, rivals like the Imperial Champlains stood in their way. Vice Lords, Champlains and Egyptian Cobras spread their influence into other west side neighborhoods like East Garfield Park, West Garfield Park and the Near West Side in the 1960s.  The Imperial Champlains set up operations in the Grace Abbott housing projects at 14th and Ashland and Henry Horner projects in the Near West Side neighborhood in the 1960s.  The Champlains continued to fight Cobras and Vice Lords but it was a losing battle by the late 1960s as the gang continued to shrink in size.  In the early 1970s the Imperial Champlains at last fully assimilated with the Vice Lords and became a branch known as “Imperial Vice Lords.” The Imperial Vice Lords landed in the Austin neighborhood at Chicago Avenue and Austin Avenue in the early 1970s.  In this community the Imperial Vice Lords met another Vice Lord branch led by Bennie Lee called the “Insane Vice Lords” from Madison Street and Cicero Avenue and the two branches became close.  In the year 1975 the leader of the Insane Vice Lords Bennie Lee was incarcerated and leadership of the Imperial Vice Lords was also no longer existent, it was at this point that both IVL gangs came together to form the “Imperial Insane Vice Lords,” and there was a new leader of this Vice Lord group Sidney “Don Sid” “Prince Symphony Sid” “Prince Shy Ku Auton” Hughes that led the organization and personally oversaw all operations in the Grace Abbott IIVL buildings until 1982 when he was convicted of rape charges.  Afterward Mathew “DJ” Williams took over as the leader of all operations for 20 years.  Under Williams’ leadership the IIVLs grew incredibly on the west side of Chicago mainly in Austin neighborhood and the public housing projects on the west side.  Williams also opted to allow all races into the organization in 1985 when the Vice Lord nation bestowed that option on all branches.  The IIVLs opened operations in the north side neighborhoods of Uptown and Albany Park in the 1980s and 1990s.  The IIVLs also opened on the south side at 71st and Jeffery in the South Shore neighborhood and they also opened in the suburbs of Elgin and Joliet. The Imperial Insane Vice Lords still operate in large numbers presently; therefore, the spirit of the Imperial Champlains is still alive with the IIVL organization. Please send in 1940s, 1950s, 1960s and 1970s pics! Questions: What exact year did the Champlains start, was it 1948 or 1949? Who was the founder of the Champlains and what happened to him? Who were the Champlain leaders from the 40s to the early 1970s and what years were they in charge? What year did Champlains open in the Henry Horner and Grace Abbott projects? What exact year did Champlains became Imperial Vice Lords? Who was the first Imperial Vice Lord leader and what happened to him? What year did Imperial Vice Lords open up in the Austin neighborhood at Chicago Avenue and Austin? What year did the north side sections open? What year did 71st and Jeffery open? What year did Elgin open? What year did Joliet open?</summary>

~4600 characters. What do you think? A little excessive for a summary?

@pathawks
Copy link
Member

pathawks commented Jul 9, 2017

If this is what the user has provided as a summary, I think it is our job to output it as is.

@ghost
Copy link
Author

ghost commented Jul 9, 2017

User did not provide as summary. Jekyll provided as excerpt.

@ghost
Copy link
Author

ghost commented Jul 9, 2017

Seems there won't be an appetite here to make decisions for users, perhaps due to long-held use of this plug-in. I'll close this and hope core can trickle down some reasonable opinion on truncation for post excerpts.

@ghost ghost closed this as completed Jul 9, 2017
@pathawks
Copy link
Member

pathawks commented Jul 9, 2017

User did not provide as summary. Jekyll provided as excerpt.

I understand now what you are saying. If a user did not provide a custom excerpt, the one generated by Jekyll could possibly be huge.

That is a valid concern, but one that should be tackled in Jekyll Core. Since we have no way of knowing if the excerpt was generated or explicitly provided, I feel like we shouldn't be monkeying with it on our end.

Thank you for your enthusiasm @jhabdas. I certainly do not mean to discourage you from making Jekyll better for all of us.

@ghost
Copy link
Author

ghost commented Jul 9, 2017

Knowledge and wisdom are fuel. And I know you have Hawk eyes and appreciate you sharing them.

@jekyll jekyll locked and limited conversation to collaborators Jun 2, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants