Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpanded links in <content>...</content> elements #69

Closed
ilg-ul opened this issue Oct 2, 2015 · 7 comments
Closed

Unexpanded links in <content>...</content> elements #69

ilg-ul opened this issue Oct 2, 2015 · 7 comments

Comments

@ilg-ul
Copy link

ilg-ul commented Oct 2, 2015

I just installed this nice plug-in to my site (http://gnuarmeclipse.github.io/feed.xml) and when I viewed the articles in feedly I noticed the images are not ok.

checking the xml, I discovered something like this:

&lt;p&gt;&lt;img src=&quot;%7B%7B%20site.baseurl%20%7D%7D/assets/images/2015/github-gae-header.png&quot; alt=&quot;GNU ARM Eclipse GitHub Home&quot;&gt;&lt;/p&gt;

obviously the {{ site.baseurl }}was not expanded properly in the <content>...</content> elements. I guess the same happens in the <summary>...</summary> elements too, but I can't prove it, my site has simple summary paragraphs.

would it be possible to expand the variables when generating the feed.xml file, and produce a functional page?

@parkr
Copy link
Member

parkr commented Oct 2, 2015

Similar to #58 and #61. We have a thought in mind for a solution but it introduces another problem.

@ilg-ul
Copy link
Author

ilg-ul commented Oct 2, 2015

I guess that the problems are related, but I'm not sure they are exactly the same problem. Perhaps trying to identify each individual problem and then address them one by one would help.

In this case just performing the substitution before escaping the html chars might be enough.

@parkr
Copy link
Member

parkr commented Oct 2, 2015

They are all symptoms to the same issue: the feed is not fully rendered because it's constituent pieces are not rendered (e.g. posts)

@ilg-ul
Copy link
Author

ilg-ul commented Oct 3, 2015

Then probably it would be safer to revert to RSS and use only the excerpts, which, at least in my case, are simply enough to be correct.

@leo
Copy link

leo commented Oct 3, 2015

Please neither revert to RSS, nor only show excerpts. It's important that we'll find a solution for this problem without cutting off a piece of the awesomeness of this plugin.

@ilg-ul
Copy link
Author

ilg-ul commented Oct 3, 2015

If there is anything I can do to help you fix the problem, please let me know. Unfortunately my experience with Jekyll/Ruby is not enough to take an active path, but I can do some testing, if useful.

@pathawks
Copy link
Member

This should be fixed by #73

@parkr parkr closed this as completed Dec 13, 2015
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants