-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noscript fallback solution slows down site generation #17
Comments
It seems like, if |
? |
Seems reasonable to me. 🎄 ? |
There isn't a solution I really like in this case. On one hand, the HTML is true. On the other, it becomes slow by default. Jekyll 3 won't have this issue because jekyll-gist won't be bundled by default. @benbalter: any thoughts here? |
The namespaced config var makes sense to me. Opened #26 before seeing this, which comes at the same problem from a different direction. In any event, I suspect it should be disabled locally. |
Hi,
First, thanks a lot for this Jekyll core extension :)
Issue
After updating to version v1.3.1, I've noticed that generating static websites on my local machine were taking 5 sec to 20 sec. After rolling back to v1.2.1, my website took 0.1 sec to generate.
I started investigating, and found out that the new
noscript
fallback feature is to blame (#7), since it depends on a connection, instead of handling everything locally.I understand that this feature is desirable for RSS feeds and many public facing websites, but Jekyll's speed is one of its great features.
Is it interesting having an option where users could deactivate the
noscript
fallback? something like:The text was updated successfully, but these errors were encountered: