Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use css variables instead? #573

Closed
jimmywarting opened this issue Feb 15, 2021 · 1 comment
Closed

use css variables instead? #573

jimmywarting opened this issue Feb 15, 2021 · 1 comment

Comments

@jimmywarting
Copy link

it would be nice to auto select css variables based on prefer color

:root {
  --color: #fff;
}

@media (prefers-color-scheme: dark) {
   :root {
     --color: #000;
   }
}

There is less need to use sass/scss nowdays i think, wish you did stick with vanilla css instead.

There will be less need to redefine all css ruls in each @media since you only need to change the variables
https://codyhouse.co/blog/post/css-custom-properties-vs-sass-variables

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyll jekyll locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants