Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device ID Validation too stringent? #46

Closed
AdamVenn opened this issue Apr 30, 2019 · 0 comments
Closed

Device ID Validation too stringent? #46

AdamVenn opened this issue Apr 30, 2019 · 0 comments
Assignees
@JElchison

Comments

@AdamVenn
Copy link

Thank you for your super duper program! I used it with success, but I had to comment out lines 309 and 334 (validate device/parent device identifier) because the validation was a little too strict for my OS - my device ID was mmcblk0 and I think that may not have satisfied the regex. I don't know how this would affect other systems but if it won't mess things up, I would suggest loosening the validation a little.

Pop!_OS, System76 Darter Pro, using format-udf on an SD card
walterav1984 added a commit to walterav1984/format-udf that referenced this issue Feb 10, 2020
@walterav1984
add linux mmcblk0 sdcard support fixes JElchison#46
5d638c9 
Some SDcard readers identify the SDcard block device with /dev/mmcblk0 or /dev/mmcblk1 instead of  /dev/sdX used by regular USB storage devices. Partitions on these blockdevices are identified with an aditional 'p' like the nvme. 

This fixes JElchison#46 , however I cannot verify mmcblk1 since I only have 1 device.
@walterav1984 walterav1984 mentioned this issue Feb 10, 2020
Closed
@JElchison JElchison mentioned this issue Feb 16, 2020
Closed
@JElchison JElchison self-assigned this Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JElchison JElchison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add linux mmcblk0 sdcard support fixes #46 walterav1984/format-udf
2 participants
@JElchison @AdamVenn