-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem of Collapsed Tabs when Viewport changes (landscape/portrait mode) #34
Comments
The script functions as it should, you need to amend the media queries to suit your application. |
Hi, I think I understand what you mean. If you understand right, the problem is that, if you switch from accordion to tabs, and the accordion is collapsed, the tab view shouldnt be collapsed. |
Hi Jelle, that is exactly what I meant. Thanks for the fix! I am impatient for the release :) And "maketimetodesign" was not right with his answer: you cannot fix this with the own media queries, because you can´t set the media queries this way, so that they will work for ALL devices... |
Hi, You can download the new release by updating through bower or by downloading the latest version on Github |
Ah okay, thought this will be just after it will be seen in the "releases timeline". Thanks again! |
You're right, I forgot to release an actual version :). Here it is: https://github.com/jellekralt/Responsive-Tabs/tree/v1.4.1 |
Hehe, so I wasn't that wrong :D |
Hi there,
by adding > startCollapsed: 'accordion' < to the javascript function, on a mobile device the accordions starts collapsed, but on higher widths normally the first tab should be open. So far, so good.
Problem:
if you have a device, which has a lower width than the media query breakpoint, the accordion start collapsed as it should.
But if you change now e.g. from portrait mode to landscape mode, and the resolution of the device gets bigger than the media query, all the tabs are still collapsed (because the device started with a collapsed accordion)
There should be some check after passing the width of the media query....otherwise this leads to a faulty impression.
The text was updated successfully, but these errors were encountered: