Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error not raised when constructing a SoundSequence with end_with_interval=True and too long sound #42

Closed
Jellevanderwerff opened this issue Sep 15, 2023 · 1 comment

Comments

@Jellevanderwerff
Copy link
Owner

The doesn't raise a helpful error:

seq = thebeat.Sequence([500, 500, 10], end_with_interval=True)
s = thebeat.SoundStimulus.generate(duration_ms=50)
ss = thebeat.SoundSequence(s, seq)

Whereas this does:

seq = thebeat.Sequence([10, 500, 500], end_with_interval=False)
s = thebeat.SoundStimulus.generate(duration_ms=50)
ss = thebeat.SoundSequence(s, seq)
@Jellevanderwerff
Copy link
Owner Author

Also ran into a frame rounding error that wasn't caught/warned and rounded. Cannot reproduce now but raises a NumPy ValueError like "shape (2501,) couldn't be broadcast into shape (2500,)", or the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant