Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issue between screenshots #23

Closed
anthonylavado opened this issue Sep 27, 2019 · 6 comments
Closed

Fix spacing issue between screenshots #23

anthonylavado opened this issue Sep 27, 2019 · 6 comments
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest issues, see hacktoberfest.digitalocean.com help wanted Extra attention is needed

Comments

@anthonylavado
Copy link
Member

Looks like I messed this up in #8. The screenshots don't have enough horizontal space to show up, and this is introducing scrollbars in at least Chrome (I didn't see these in Safari when working on it).

@anthonylavado anthonylavado added good first issue Good for newcomers Hacktoberfest Hacktoberfest issues, see hacktoberfest.digitalocean.com help wanted Extra attention is needed labels Sep 30, 2019
@shawnofthedev
Copy link

I can take this one but I don't have anything with Safari to test against.

@anthonylavado
Copy link
Member Author

That's no problem, I can review it :-)

@cewert
Copy link
Contributor

cewert commented Oct 1, 2019

I also worked on this and submitted a PR. I didn't see that shawnofthedev said he was going to get this one, sorry.

No hard feelings if my code doesn't get used :)

@anthonylavado
Copy link
Member Author

I'll look at both, don't worry. They're both valid in my eyes 👍

@shawnofthedev
Copy link

I also will have no hard feelings as you should choose the one that fits best 👌

@anthonylavado
Copy link
Member Author

fixed in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest issues, see hacktoberfest.digitalocean.com help wanted Extra attention is needed
Development

No branches or pull requests

3 participants