Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double tap skip causes freezing UI #427

Closed
eightsheep67 opened this issue May 3, 2022 · 3 comments · Fixed by #428
Closed

double tap skip causes freezing UI #427

eightsheep67 opened this issue May 3, 2022 · 3 comments · Fixed by #428
Labels
bug Something isn't working

Comments

@eightsheep67
Copy link

Describe the bug

double tap skip causes freezing UI, and need 2s to recover.
I hope next build can go back to swipe gesture, more efficient.

Application version

1.0.0 (75)

Where did you install the app from?

TestFlight

Device information

iPhone 12 mini

OS version

15.4.1

Jellyfin server version

10.7.7

@eightsheep67 eightsheep67 added the bug Something isn't working label May 3, 2022
@LePips
Copy link
Member

LePips commented May 3, 2022

Thank you for the issue.

@PangMo5 if you could possibly look at this. As a temporary measure, I will be able to re-implement swipe as an alternative option soon (which is ultimately planned).

@PangMo5
Copy link
Member

PangMo5 commented May 3, 2022

In fact, UI gestures are recovered in 1 second after double-tap.
In order to minimize the impact on UX, if you tap it during recovery, the tap gesture will be executed immediately after recovery.
This is pretty much the same condition as YouTube, and I don't think there will be a big problem

And Personally, I don't think swipe gestures suit the video player.

Instead additional, I'll develop a function that can adjust the slider value with pan gesture when I have time.
Like any other useful video players.

@lesclaz
Copy link

lesclaz commented May 3, 2022

Describe the bug

double tap skip causes freezing UI, and need 2s to recover.

I hope next build can go back to swipe gesture, more efficient.

Application version

1.0.0 (75)

Where did you install the app from?

TestFlight

Device information

iPhone 12 mini

OS version

15.4.1

Jellyfin server version

10.7.7

Well, this doesn’t happen to me. I see that it works very well, I don’t see any differences with YouTube in terms of speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants