Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embuary Configs #14

Open
mcarlton00 opened this issue Aug 16, 2020 · 9 comments
Open

Embuary Configs #14

mcarlton00 opened this issue Aug 16, 2020 · 9 comments
Labels
documentation Improvements or additions to documentation

Comments

@mcarlton00
Copy link
Member

It looks as though the Embuary skin is hardcoded to look for "Embycon" when it's gathering data for the home screen menu and widgets. We'll need to add some docs for populating the home screen from Jellycon so we can replicate the same behavior.

From a comment on reddit we can use as a base:

To add libraries across the top under "My media"

  1. Settings
  2. Home and hubs
  3. Edit Menu Configuration
  4. Select the + symbol on an existing entry
  5. Move to your new entry and select the edit symbol (box and pencil)
  6. Add-On -> Video Add-On -> JellyCon -> Global Lists -> Movies -> Movies - Show All -> Create menu item to here
  7. Repeat for any libraries you want linked on top.

To add widgets:

  1. Settings
  2. Custom widgets
  3. Edit path of an entry
  4. Add-On -> Video Add-On -> JellyCon -> Global Lists -> Movies -> Movies - Recently Added (20) -> Use as widget
  5. Go to "Home and hubs"
  6. Edit Widget Configuration
  7. Select the Edit icon of an entry
  8. Select your custom node from the bottom of the list
@mcarlton00 mcarlton00 added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Aug 16, 2020
@dudeoflife25
Copy link

Is there a way to configure jellyfish logins to work with embuary and jellycon?

@mcarlton00
Copy link
Member Author

I'm not sure what you mean. There's no logins with Embuary, it's just the skin

@dudeoflife25
Copy link

How do I access my Jellycon users instead of just kodi user switching?

@mcarlton00
Copy link
Member Author

Add-Ons -> JellyCon -> Add-on Actions -> [Change user]

Hopefully we'll find a way forward and get all the nicer features of the skin to work properly again

@ambroisie
Copy link

An easy way to Just Make It Work™ would be to fork the theme's repo and do s/embycon/jellycon and s/Embycon/Jellycon. Otherwise, we could try to make it work upstream directly, or is the author against it for some reason?

@mcarlton00
Copy link
Member Author

I've discussed this with sualfred a bit already actually. So far there's not a great answer, but I do have ideas that I have yet to investigate.

The summarized version:

  • Everything in Embuary is indeed hardcoded to look for Embycon
  • There's no straightforward way to change this (over 1000 replacements when I was testing), and there's no way to import a templated config (yet. Maybe something kinda sorta going in this direction in the future, but not anytime soon.)
  • To me personally, forking the skin isn't on the table for a few reasons
    • The license is more restrictive than I like, and doesn't allow a full rebranding. It would have to be labeled "Embuary for Jellyfin" or something similar and I'm not 100% sure how much we could change. It might be possible to get permission to do otherwise, but combined with other reasons it's just not something I want to put time to.
    • Maintaining a skin is a whole different beast than maintaining a code addon. A lot more xml and templating vs Python.
    • Frankly, I don't want to. With how functionally different it is, and the fact that I'm already maintaining 2 Kodi addons and a Mopidy extension, on top of real life and server support stuff, I simply don't have the time to devote to learning how to maintain a skin as well.

So it's not looking great at this point. I do have 2 ideas that I haven't fully traced out yet, but there's some hope for something semi-automagical.

  • Including a template Embuary config file pre-filled in for Jellyfin related fields in this repo where users can easily download it and put it on their Kodi boxes. Real easy on a PC, less easy on an android based device.
  • Detecting if Embuary is installed and run a sort of mini-wizard to modify it's config file. This is probably the closest to a "user friendly" option I have, but it's also highly frowned upon to modify another addon's config files, so this would need a lot of careful thought and error checking to prevent unintended side effects.

Unfortunately, neither of these options are 100% foolproof. For example, the fast user switcher on the left side of the skin is hardcoded to Embycon and there's no way to override it currently.

@mcarlton00 mcarlton00 pinned this issue Sep 4, 2020
@Cosmonear
Copy link

I think that the "run a mini-wizard to modify it's config file" is the best for now because we are a lot with Kodi Boxes, or Kodi install on TV.

@dflvunoooooo
Copy link

It would be awesome if it would be possible to use Jellycon with Embuary.

@cch85
Copy link

cch85 commented Feb 22, 2023

I had it working on Matrix mostly by cloning Jellycon addon an renaming with the embycon addon (plugin.video.jellycon-0.4.4+py3 at the time) . This made embuary believe it was using embycon. That work but it has strong limitation since you would not get easily the latest Jellycon update.
Mostly I changed in addon.xml this way:

And also updated in jellycon files plugin.video.jellycon to plugin.video.embycon

I think the mini-wizard idea mcarlton00 would probably the best. It would just need to do what I did manually.

Note it does not work for me currently on Nexus, but even an unmodified version of Jellycon does not, but Nexus is not very stable right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants