Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "screen lock" feature #77

Closed
jakobkukla opened this issue Aug 30, 2020 · 5 comments · Fixed by #108
Closed

Add "screen lock" feature #77

jakobkukla opened this issue Aug 30, 2020 · 5 comments · Fixed by #108
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects

Comments

@jakobkukla
Copy link

Describe the feature you'd like
Add a button in the video controls to lock the screen from accidental touch inputs. MX Player had this feature for years and Netflix recently added this too. Would love to have it in the Jellyfin app as well.

Additional context
Here are some screenshots from Netflix and MX Player:

Screenshot_20200830-163607

Screenshot_20200420_170917 0

@jakobkukla jakobkukla added the enhancement New feature or request label Aug 30, 2020
@Maxr1998 Maxr1998 added the exoplayer Related to the ExoPlayer integration label Aug 30, 2020
@Maxr1998
Copy link
Member

Should be possible, at least for the native player.

@jakobkukla
Copy link
Author

Would be nice to see it in the ExoPlayer implementation too. I'm looking forward to use it more in the future since it's much more stable than the native player for me. :)

@JulioNahum
Copy link

Would be nice to see it in the ExoPlayer implementation too. I'm looking forward to use it more in the future since it's much more stable than the native player for me. :)

Of course. The day will come when the Exoplayer player is 100% operational, with all the bugs corrected and improvements, it will have the possibility of replacing the web player. That is the idea as I see it, and it would be a great success.

@Maxr1998
Copy link
Member

Maxr1998 commented Aug 30, 2020

Would be nice to see it in the ExoPlayer implementation too. I'm looking forward to use it more in the future since it's much more stable than the native player for me. :)

With native player, I specifically mean the ExoPlayer ^^
For the web player, that need to be adressed in jellyfin-web.

Of course. The day will come when the Exoplayer player is 100% operational, with all the bugs corrected and improvements, it will have the possibility of replacing the web player. That is the idea as I see it, and it would be a great success.

Yep, that's the long-term plan.

@jakobkukla
Copy link
Author

With native player, I specifically mean the ExoPlayer ^^
For the web player, that need to be adressed in jellyfin-web.

Got it.

@nielsvanvelzen nielsvanvelzen added this to To do in v2.0.0-rc.4 via automation Sep 9, 2020
@nielsvanvelzen nielsvanvelzen moved this from To do to Done in v2.0.0-rc.4 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
No open projects
v2.0.0-rc.4
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants