-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Mojave (10.14) support ? #46
Comments
This depends entirely on if outside contributors are able to get it working. Note that the build system uses Catalina, so this may pose issues to shipping for older versions. |
If we want support of Mojave or earlier, we need to set the macOS deployment target to be lower. It not only needs to be set for jellyfin media player itself but also all its dependencies (mpv / FFmpeg and their dependencies as well). However, homebrew is configured to target the macOS version it is built on and GitHub Actions doesn't provide older macOS. This means we need to build everything from source and set the deployment target to be 10.14. So with the help of mpv-nightly-build I hacked the homebrew formulae and build a version that targets 10.13, and runs well in a vm. But it takes ~2.5hrs to finish. We could possibly strip out some unnecessary dependencies (maybe some encoders for ffmpeg), but the total time would still be substantially longer than before. Caching may help but I read somewhere that GitHub Actions only keep cache for a week or so. @iwalton3 not sure what you think, maybe we could have two build configs where mpv is only built on release branch and on test branch we just simply run Just a side note if we want to support Mojave: for macOS 10.14.3 and earlier, we need to bundle swift libraries otherwise the user has to install swift runtime. |
I'd say if someone in the community wants to do this that's fine, but the 2.5 hour build process thing is kind of a deal-breaker. I am of course willing to change my mind on this if a ton of people request it though. |
Jellyfin has clients for all kinds of tv os, but still no easy-to-use clients for mac except for kodi plugin and its performance is not ideal on mac. |
Yeah it's just unfortunate that all the build infrastructure and packaging has moved on. So you have to do things like multi-hour CI builds. |
If someone can make a GitHub Actions job that builds in under 40 minutes I'd gladly use it. |
I use Chrome for my old Mac and it works pretty good (Transcode 5.1 to Stereo). Maybe give that a try? |
Probably not worth the effort of having a pre Catalina version of the client in regards to the number of potential users. And I support the fact that ressources should concentrate on new features. |
So, may I ask that is there any release for 10.14 now? |
@findyy99 I don't think there is, as we have discussed above. But it's fairly simple to build on your own (https://github.com/jellyfin/jellyfin-media-player#building-for-macos) |
1.8 is no longer compatible with Catalina and requires at least Big Sur. We can still downgrade to 1.7, but that’s really unfortunate |
Mojave has been EoL for two years. You will have to follow the instructions to build yourself on unsupported operating systems. |
Any chance to make this nice application to work on Mojave or is it mandatory bound to Catalina ?
The text was updated successfully, but these errors were encountered: