Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow application icon to be themed on Linux #59

Closed
viggy96 opened this issue Apr 22, 2021 · 5 comments · Fixed by #75
Closed

Allow application icon to be themed on Linux #59

viggy96 opened this issue Apr 22, 2021 · 5 comments · Fixed by #75
Labels
enhancement New feature or request

Comments

@viggy96
Copy link
Contributor

viggy96 commented Apr 22, 2021

Is your feature request related to a problem? Please describe.
Jellyfin Media Player uses its own icon for the taskbar/dock on Linux instead of specifying a generic icon that can be themed.

Describe the solution you'd like
Use generic icons

Describe alternatives you've considered
I have tried editing the *.desktop file associated with Jellyfin Media Player, but it only changes the icon in the application list, but not the taskbar/dock.

Additional context
Papirus provides icons for Jellyfin. I haven't checked, but I would imagine that other icon themes have icons for it as well.

@viggy96 viggy96 added the enhancement New feature or request label Apr 22, 2021
@iwalton3
Copy link
Member

The icon is already set to com.github.iwalton3.jellyfin-media-player which is not an absolute file path. It has to be named like that for Flatpak. Is there something I can do to make it able to be themed?

@viggy96
Copy link
Contributor Author

viggy96 commented Apr 23, 2021

Hmmm, you're right. Instead I'll submit a request to the icon theme to have them put in another link for Jellyfin Media Player.

@viggy96 viggy96 closed this as completed Apr 23, 2021
@viggy96
Copy link
Contributor Author

viggy96 commented Apr 23, 2021

It appears this is in progress on this issue: PapirusDevelopmentTeam/papirus-icon-theme#2007

@viggy96
Copy link
Contributor Author

viggy96 commented May 1, 2021

Actually I just realised that the window icon is set here:

#if defined(Q_OS_WIN) || defined(Q_OS_LINUX)
    // Setting window icon on OSX will break user ability to change it
    app.setWindowIcon(QIcon(":/images/icon.png"));
#endif

@viggy96 viggy96 reopened this May 1, 2021
@viggy96
Copy link
Contributor Author

viggy96 commented May 1, 2021

Icon themes change the icon in the application list for the user, but once the application is opened, the taskbar/dock button shows this hardcoded icon no matter which icon theme the user has selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants