Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Subtitles format bugged when loaded automatically #643

Open
kradear opened this issue May 17, 2024 · 23 comments
Open

[Bug] Subtitles format bugged when loaded automatically #643

kradear opened this issue May 17, 2024 · 23 comments
Labels
bug Something isn't working

Comments

@kradear
Copy link

kradear commented May 17, 2024

Describe the bug
When subtitles are set to load automatically (Always - Default, etc), they load crammed on the side. You need to turn them off and on or switch to different ones to see their format fixed.

To Reproduce
Steps to reproduce the behavior:

  1. Open Jellyfin Media Player
  2. Set subtitles to load automatically in settings
  3. Click play on any movie/series
  4. See subtitles first load crammed on the side

Expected behavior
Subtitles loading automatically in correct format.

Screenshots
image

Desktop:

  • OS: Windows 11 Home 23H2
  • Version 1.10.0
  • Installation Method: windows installer

Additional context
I have a custom CSS layout set on the server side and custom options set in "Other" under client settings for the player, changing mostly subtitles size and positioning.
Clearing both and going back to default with a restart of the server/client did not fix the problem.

@kradear kradear added the bug Something isn't working label May 17, 2024
@HijackHornet
Copy link

I have the same issue since the update. Putting the view in fullscreen then back to normal size fix the issue for the current episode but it comes back on the next media.

@PCJones
Copy link

PCJones commented May 17, 2024

I have the same problem and can use the same fix (close&open fullscreen).

OS: Windows 11 Home 23H2
Version 1.10.0 / 1.10.1
Installation Method: windows installer

I have 2 displays, just in case this might be relevant.

@nathangur
Copy link

This doesn't seem to occur with all subtitles either. I haven't looked into the differentiating factor yet.

@kofzhanganguo
Copy link

Snipaste_2024-05-18_14-14-03
Same problem, the subtitle format is SRT, and the subtitles will be displayed correctly when double-clicking the full screen.

@okphilo

This comment has been minimized.

1 similar comment
@ElPenguin

This comment has been minimized.

@CassieRoseZA

This comment has been minimized.

@mahriman
Copy link

Not much new info, but I'll add it for reference anyway:

  • Issue does not happen when the media file has a corresponding .srt
  • Issue does happen also after jellyfin with other player has extracted the subtitle file from the stream for the media file
  • Issue started after Jellyfin 10.9.0 upgrade and corresponding JMP update

@nathangur
Copy link

I took a look at what might be causing this in the source code but came up empty handed. This might be an issue from the mpv player Jellyfin uses on Windows since I don't thing this is occuring on other OS's

@SMSourov
Copy link

SMSourov commented Jun 7, 2024

Try the latest version. It seems to fixed the bug.

@mahriman
Copy link

mahriman commented Jun 7, 2024

Try the latest version. It seems to fixed the bug.

Just updated to 1.11.0. Though the update required a restart of Windows (which I haven't done) the issue is still persistent. Someone else who has the ability to reboot might be able to confirm if that solves it, but otherwise it seems to still linger.

@barriteau
Copy link

Try the latest version. It seems to fixed the bug.

Just updated to 1.11.0. Though the update required a restart of Windows (which I haven't done) the issue is still persistent. Someone else who has the ability to reboot might be able to confirm if that solves it, but otherwise it seems to still linger.

Still happening here after booting and re-authenticating

@ElPenguin
Copy link

With Jellyfin 10.9.6 and Jellyfin Media Player 1.11.0, it work

@mahriman
Copy link

mahriman commented Jun 7, 2024

With Jellyfin 10.9.6 and Jellyfin Media Player 1.11.0, it work

Strange, that is what I'm running and I still have the issue.

@kradear
Copy link
Author

kradear commented Jun 7, 2024

Jellyfin 10.9.4 and JMP 1.11.0; seems fixed.

edit: still happening, but more random than before

@mahriman
Copy link

mahriman commented Jun 7, 2024

Okay I did a restart and after that it seems to be wowrking as expected on 10.9.6 / 1.11.0

@kofzhanganguo
Copy link

Jellyfin Media Player 1.11.0 subtitles are still the same as the previous version and have not been fixed.
image
I still don't understand if this problem is a bug that is difficult to fix?

@mahriman
Copy link

mahriman commented Jun 8, 2024

Okay I did a restart and after that it seems to be wowrking as expected on 10.9.6 / 1.11.0

Correction, does not work still. No idea why it intermittently seemed to start working for one media file that previous had problems.

@SMSourov
Copy link

I updated again and the subtitle is broken again. 🙁

@pulpul-s
Copy link

This is probably a bug in libmpv-2.dll. I replaced the file with the one from dated 20240304 and it works.
https://sourceforge.net/projects/mpv-player-windows/files/libmpv/
mpv-dev-x86_64-v3-20240304-git-9ac791c.7z

@Uncle-Tio
Copy link

Uncle-Tio commented Jun 19, 2024

This is probably a bug in libmpv-2.dll. I replaced the file with the one from dated 20240304 and it works. https://sourceforge.net/projects/mpv-player-windows/files/libmpv/
mpv-dev-x86_64-v3-20240304-git-9ac791c.7z

I also confirm. I decided to test other versions:

  • mpv-dev-x86_64-v3-20240304-git-9ac791c - Working
  • mpv-dev-x86_64-v3-20240414-git-6a8b130 - Working (Supposedly the last one working)
  • mpv-dev-x86_64-v3-20240421-git-b364e4a - Broken (closest from above)
  • mpv-dev-x86_64-v3-20240526-git-88f20a7 - Broken
  • mpv-dev-x86_64-v3-20240609-git-d2bd77a - Broken
  • mpv-dev-x86_64-20240623-git-265056f - Broken (latest)

mpv-dev-x86_64-v3-20240414-git-6a8b130 seems the closest to the stable version of mpv as well.
(I don't know if v3 or not v3 makes a difference)


mpv-dev-x86_64-20240513-git-61f72bd (from here) is the version included in 1.11.1.
I don't think this problem has come to the attention of the dev yet... theoretically it's simple to solve?

@PCJones
Copy link

PCJones commented Jun 25, 2024

Could one of you who did some more in-depth testing create an issue?
https://github.com/mpv-player/mpv/issues

@XDark187
Copy link

I'm having the same issue I was able to fix it be replacing the libmpv-2.dll with this version "mpv-dev-x86_64-v3-20240414-git-6a8b130", tried the latest version but it had the same issue.
Thanks to @Uncle-Tio @pulpul-s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests