Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an API endpoint to submit offline listens #60

Closed
Maxr1998 opened this issue Nov 7, 2023 · 0 comments
Closed

Provide an API endpoint to submit offline listens #60

Maxr1998 opened this issue Nov 7, 2023 · 0 comments

Comments

@Maxr1998
Copy link
Member

Maxr1998 commented Nov 7, 2023

At the moment, the playback session API doesn't allow you to submit sessions from the past, so playback reporting plugins like the ListenBrainz and Last.fm plugin have no (proper) way to record such listens.1

A long time suggestion has been to add a timestamp to the ReportPlaybackStopped API
But because this would require a separate request for every recorded offline listen, I don't think this would be a good solution.
Instead, clients should be able to submit a list of listens once they are online again, which could then be submitted to the activity log and be broadcast to playback reporting plugins so that they could pick them up and submit them to an external service.

By making this an official API, behavior across various plugins could be streamlined and clients would only need to use the Jellyfin API and not need to bother with external services or third-party APIs.
Moreover, an official API should hopefully increase adoption among third-party music playback clients.

I've discussed this with the ListenBrainz plugin developer already and posted some further thoughts in lyarenei/jellyfin-plugin-listenbrainz#51.

There's also a draft for the API design in that ticket. I'd love to discuss the API proposition here further, and afterward work on getting this into the server, if accepted.

[1] The ListenBrainz plugin offers an alternative mode that does actually allow to retroactively submit listens, however, it comes with its own share of disadvantages as outlined in the docs above, and also requires one request per reported offline playback.

@cvium cvium transferred this issue from jellyfin/jellyfin Nov 7, 2023
@jellyfin jellyfin locked and limited conversation to collaborators Nov 7, 2023
@cvium cvium converted this issue into discussion #61 Nov 7, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant