Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.4.2 breaks osc on external players #321

Closed
Bestfast opened this issue Feb 25, 2023 · 6 comments
Closed

v2.4.2 breaks osc on external players #321

Bestfast opened this issue Feb 25, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Bestfast
Copy link

Bestfast commented Feb 25, 2023

Describe the bug
As title says, no osc is showing with 2.4.2. Reverting to 2.2.0 I can see it.
Tried with mpv.net with https://github.com/maoiscat/mpv-osc-modern/

@Bestfast Bestfast added the bug Something isn't working label Feb 25, 2023
@iwalton3
Copy link
Member

#320

Should be a duplicate of the issue above

@iwalton3
Copy link
Member

Also would you like me to port the MPV Shim trickplay previews to work with that specific OSC?

@Bestfast
Copy link
Author

#320

Should be a duplicate of the issue above

sorry, didn't check for previous issues. my bad.

Also would you like me to port the MPV Shim trickplay previews to work with that specific OSC?

if you could that would help a lot, feel free to close as a duplicate though

@iwalton3
Copy link
Member

iwalton3 commented Feb 25, 2023

Here is a version of that osc which uses my thumbnail seek provider: https://github.com/iwalton3/mpv-osc-modern/

@iwalton3
Copy link
Member

It you install the latest CI version the above script has been tested and is known to work. Follow the directions in the README. Specifically you need to configure an alternate OSC and install the font.

@iwalton3
Copy link
Member

Update 2: I added a compatibility layer so that Jellyfin MPV Shim will do trickplay with any third-party OSC which works with https://github.com/po5/thumbfast.

To do this, just download one of the OSCs, place it in the scripts folder, and disable the thumbnail_osc_builtin option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants