Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional logging for DLNA device info before matching with a profile #31

Open
aoberoi opened this issue Nov 16, 2023 · 1 comment
Open

Comments

@aoberoi
Copy link

aoberoi commented Nov 16, 2023

First, I am willing to contribute and help land this change. It will likely be a tiny one-liner. If I see some general agreement, esp from the core team, then I'll dive into the code and work on a PR.

Currently, DLNA profile matching is sort of a guess-and-check process, and encourages folks to be somewhat loose/sloppy with defining a custom profile to match their specific devices. Right now, I have no idea what fields in the UI such as Manufacturer, Model Name, Model Number, etc. are even matched against. The only fields that seem to be approachable are the headers, because headers are output in some existing logs today.

In my opinion, logging out exhaustive info about a connected device, even if its going to match to a generic default profile, would help folks craft more useful profiles. These would be specific enough to address a whole family of devices with the same capabilities (which will continue to evolve as new hardware comes out and new software for existing hardware also comes out). With better quality custom profiles, people might actually be able to share them with each other or back to the server project. I could see potential for a better UI being developed around this, but I think the first step is just a simple log line with as much detail as possible about DLNA devices.

It seems like the DLNA code might be moving out of this repo (see: jellyfin/jellyfin#10558). Let me know if I need to target a different branch or repo to help align with that work. Thanks!

@barronpm barronpm transferred this issue from jellyfin/jellyfin Nov 30, 2023
@spali
Copy link

spali commented May 28, 2024

I appreciate the logging of the profile.
Maybe in a second step, why not let us show the profile details in the current device list and let us create a prefilled profile from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Team Review
Development

No branches or pull requests

2 participants