This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Changes to support Android build errors #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth also saying, if it fails to run on the device first time, I had to also follow this manually afterwards - https://medium.com/@adityasingh_32512/solved-unable-to-load-script-from-assets-index-android-bundle-bdc5e3a3d5ff |
|
lock files in the pull request by mistake. you can ignore them! |
EraYaN
suggested changes
Dec 1, 2019
|
One last thing, is that bundle required for Android? It seems like it’s generated code, if so please add it to the .gitignore file. |
That's the file removed and .gitignore updated. The file is generated is linked to this comment I added above #37 (comment) |
EraYaN
approved these changes
Dec 2, 2019
|
Alright thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few changes to allow Android build to complete.
This might have just been my environment but I also had to run this to get past an error gatsbyjs/gatsby#11406 (comment)
Now builds the Android app (and a quick test that it didnt break web worked fine)