-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to JCenter #2
Comments
As @dkanada pointed out on Riot, we should stick to a repository that is supported by F-Droid. Refs: https://gitlab.com/fdroid/fdroidserver/blob/master/fdroidserver/scanner.py#L99 |
The project can be added as a dependency from jitpack currently. It may still be worthwhile to publish somewhere else where we have more control over the build process in the future. |
Can't seem to get the source for this when trying to build the androidtv repo: FAILURE: Build failed with an exception.
|
Build failed. See the log at jitpack.io |
It's really hard to contribute if we're referencing snapshots and the repositories are not compilable. Joao |
Bumping this to give it some attention. Would be cool if we can use versioning and a proper repository for the library. |
I did try to add versioning, but it was said that it was only wanted for releases, so that one TV release is one bump in apiclient version. |
That's not the case, we are just in a somewhat nebulous state because this API client is more of a placeholder until we can get at least most of the functionality generated from a specification. We could always add versioning now though. |
Hmm I remember distinctly being told to undo the version bump and reference master-snapshot again. Currently on mobile though, so I can't look up the link. |
Otoh, doesn't matter, I appreciate versioning as well |
The current release (on Github) is actually called 0.4.0. I will create a PR to set a version and use 0.5.0 so we can actually publish a new version (4 commits since 0.4.0). edit: It seems like the current version is already set to 0.4.0 so in theory this could be published already. |
Ok so what we want to avoid is having to constantly bump versions here and in Android TV during development. That is why the initial versioning that was added needed to be reverted. For Android TV there is now a release branch that will use a specific release of this library. That allows the master branch of Android TV to track the master branch of the apiclient. Otherwise we would be constantly bumping versions while making changes here. |
This should be published to JCenter (or similar) so it can be included as a maven or gradle dependency.
The text was updated successfully, but these errors were encountered: