Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to JCenter #2

Closed
thornbill opened this issue Feb 12, 2019 · 13 comments · Fixed by #54
Closed

Publish to JCenter #2

thornbill opened this issue Feb 12, 2019 · 13 comments · Fixed by #54
Labels
enhancement New feature or request

Comments

@thornbill
Copy link
Member

This should be published to JCenter (or similar) so it can be included as a maven or gradle dependency.

@thornbill
Copy link
Member Author

As @dkanada pointed out on Riot, we should stick to a repository that is supported by F-Droid. Refs: https://gitlab.com/fdroid/fdroidserver/blob/master/fdroidserver/scanner.py#L99

@thornbill thornbill added the enhancement New feature or request label Apr 8, 2019
@thornbill
Copy link
Member Author

The project can be added as a dependency from jitpack currently. It may still be worthwhile to publish somewhere else where we have more control over the build process in the future.

@anthonylavado
Copy link
Member

anthonylavado commented Apr 8, 2019

https://bintray.com/jellyfin 👀

@jbcorreia
Copy link

Can't seem to get the source for this when trying to build the androidtv repo:

FAILURE: Build failed with an exception.

  • What went wrong:
    Could not determine the dependencies of task ':app:compileGoogleReleaseAidl'.

Could not resolve all task dependencies for configuration ':app:googleReleaseCompileClasspath'.
Could not find com.github.jellyfin.jellyfin-apiclient-java:android:master-SNAPSHOT.
Required by:
project :app > com.github.jellyfin:jellyfin-apiclient-java:master-SNAPSHOT:77043c2709-1
Could not find com.github.jellyfin.jellyfin-apiclient-java:library:master-SNAPSHOT.
Required by:
project :app > com.github.jellyfin:jellyfin-apiclient-java:master-SNAPSHOT:77043c2709-1

@jbcorreia
Copy link

@jbcorreia
Copy link

It's really hard to contribute if we're referencing snapshots and the repositories are not compilable.
I'd recommend to reference a release version instead of snapshots.

Joao

@nielsvanvelzen
Copy link
Member

Bumping this to give it some attention. Would be cool if we can use versioning and a proper repository for the library.

@AndreasGB
Copy link
Contributor

I did try to add versioning, but it was said that it was only wanted for releases, so that one TV release is one bump in apiclient version.

@dkanada
Copy link
Member

dkanada commented Jan 12, 2020

That's not the case, we are just in a somewhat nebulous state because this API client is more of a placeholder until we can get at least most of the functionality generated from a specification. We could always add versioning now though.

@AndreasGB
Copy link
Contributor

Hmm I remember distinctly being told to undo the version bump and reference master-snapshot again. Currently on mobile though, so I can't look up the link.

@AndreasGB
Copy link
Contributor

Otoh, doesn't matter, I appreciate versioning as well

@nielsvanvelzen
Copy link
Member

nielsvanvelzen commented Jan 12, 2020

The current release (on Github) is actually called 0.4.0. I will create a PR to set a version and use 0.5.0 so we can actually publish a new version (4 commits since 0.4.0).

edit: It seems like the current version is already set to 0.4.0 so in theory this could be published already.
edit2: We actually did use versions properly until recently when the library was updated. We switched to using the master branch at that time in the androidtv repository. We should probably create a separate issue to discuss versioning and keep this one for publishing to jcenter or similar

@thornbill
Copy link
Member Author

Ok so what we want to avoid is having to constantly bump versions here and in Android TV during development. That is why the initial versioning that was added needed to be reverted.

For Android TV there is now a release branch that will use a specific release of this library. That allows the master branch of Android TV to track the master branch of the apiclient. Otherwise we would be constantly bumping versions while making changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants