Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Package makes a floating windows at 2/3 of screen #11

Open
ghost opened this issue Jan 15, 2019 · 14 comments
Open

Windows Package makes a floating windows at 2/3 of screen #11

ghost opened this issue Jan 15, 2019 · 14 comments
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Jan 15, 2019

image

When normally ran with electron builder executable the display shown is a full screen environment. But when it is in the electron windows package it only shows on 2/3 of page, is this because of dependence not installed?

Is anyone able to develop an linux app image to see if there is a similar problem

@lachlan-00
Copy link

I use the linux version primarily so i can check. can you tell me what steps you'd like me to test?

When you say app image do you mean package with the commands from the readme? I've built both windows and linux packages from linux and run them both at home.

npm run package-linux

@ghost
Copy link
Author

ghost commented Jan 19, 2019

So on my windows box, when i build a executable i get a screen 2/3rds the size. for now i no longer need windows for school so i switched back to linux and now i have the same issue i had with the executable.

To replicate, I am running elementary os 5.0.

clone a fresh repository of the fork.
run npm install
then npm start

this then results in the following screen.

screenshot from 2019-01-18 22-50-53

its interesting that this happens both with the windows release package. but in the linux dev system. I wonder what the cause of it is?

does this happen to you @lachlan-00

Also note later tonight i will release a debian file hopefully for this version and we can see what changes.

@ghost
Copy link
Author

ghost commented Jan 19, 2019

So i actually get the same problem when running it as the built executable as well.

Also

BUG : when building the application, format it so that it will automatically transfer users current database.txt as well.

@lachlan-00
Copy link

lachlan-00 commented Jan 19, 2019

Oh yes, for me both Windows are not maximised. It's "full screen" but in the resolution minimum set by main.js

I didn't think anything of it as I use win+up to maximise the window and full screen for video works correctly.

I was going to play with main to see what window options I could change to make it better

@ghost
Copy link
Author

ghost commented Jan 19, 2019

Good eye i had'nt caught that. Have you edited that section of the code yet?

@lachlan-00
Copy link

titleBarStyle works great in Windows.
Still doesn't set full screen but I have looked at that yet

var windowOptions = {
            transparent: false, //supportsTransparency,
            frame: true,
            titleBarStyle: 'hidden',
            resizable: true,
            title: 'Jellyfin Theater',

@lachlan-00
Copy link

I set resizable to true and can now just double click into full screen

@dkanada
Copy link
Member

dkanada commented Jan 20, 2019

Window mode should be the default anyways, you can always click into fullscreen on window mode but fullscreen applications don't let you switch to window mode.

@lachlan-00
Copy link

lachlan-00 commented Jan 20, 2019

For me this seems to be okay. gnome-shell doesn't allow hiding the window titlebar by the looks so i set it to hide when it's linux and keep it resizeable.

        var windowOptions = {
            transparent: false, //supportsTransparency,
            frame: isWindows() ? true : false,
            titleBarStyle: isWindows() ? 'hidden' : 'default',
            resizable: true,
            title: 'Jellyfin Theater',
            minWidth: 1280,
            minHeight: 720,
            //alwaysOnTop: true,
            skipTaskbar: isWindows() ? false : true,

@Ayrler from Issue #9 might like these changes

@lachlan-00
Copy link

It looks like the windows options break the player window when i make more changes. i'll work on this at home and send a pull when i get it working correctly

@ObiWanTwo
Copy link

ObiWanTwo commented Jan 22, 2019

@lachlan-00 Using your settings, it seems that the whole window is rendered at the minimal resolution specified. If you set it to be at 360p (in order to notice the difference), going fullscreen will not dynamically change the resolution until you reload the content of the page you're visiting.

Steps to reproduce:

  1. Set minWidth: 480, minHeight: 360
  2. Start Jellyfin and go fullscreen by double clicking

Now if you want it to adapt the resolution, you need to stay on fullscreen and reload your home tab (from the side bar).

I'm clearly loading the HD images (metadata) from the get-go and they are later downscaled according to the resolution of the window. Is it possible to make it dynamically change the resolution of the displayed content without having to reload?
I know this is a minor issue, but it would be nice to fix it especially if the window becomes resizable.

@Evoley
Copy link

Evoley commented Jan 27, 2019

Has there been an update to this? I would really like to use this as opposed to a browser.

@alextomko
Copy link

Helllo - I have the same Issue on Ubuntu 16.04 running the JellyFin Theater App. Although I can double click when it opens to full-screen it leaves a black side-bar to the left and right and that stays during the movies so it is not really full-screen - it also has a black bar on top and bottom.

For example see attached screen shot of running the application with "npm start":

jellyfin

Then here is the example after double-clicking where it goes into semi-full-screen with black edges but crops out part of the application window on left and right:

jellyfin-double-click

It would be fine if it would be a true full-screen by double clicking but it cuts out part of the application on left and right along with it cuts out part of the movie on left and right and top and bottom.

@cromefire
Copy link
Contributor

I'll probably just add the standard windowbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

7 participants