Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song item detected as MusicAlbum instead of Audio in Context Menu #1950

Closed
noaione opened this issue Apr 13, 2023 · 5 comments · Fixed by #1962 or #1998
Closed

Song item detected as MusicAlbum instead of Audio in Context Menu #1950

noaione opened this issue Apr 13, 2023 · 5 comments · Fixed by #1962 or #1998
Labels
question Further information is requested waiting for input

Comments

@noaione
Copy link
Contributor

noaione commented Apr 13, 2023

Description of the bug

If you try to open the item context menu on the Music Album page for the song, it got detected or marked as MusicAlbum instead of Audio.

Steps to reproduce

  1. Open a Music Album
  2. Click on the context menu for a song (not the album itself)

Expected behavior

The song is marked as Audio.

Logs

No response

Screenshots

firefox_Em6amXjO9F.mp4

Example of a song in an album marked as MusicAlbum instead of Audio

Jellyfin

Jellyfin-web version that are correct.

Platform

Windows

Browser

Firefox

Jellyfin server version

10.8.9

Additional context

Using a modified JF-Vue that are based on 16955dd

@noaione noaione added the bug Something isn't working label Apr 13, 2023
@ferferga ferferga added question Further information is requested and removed bug Something isn't working labels Apr 13, 2023
@ferferga
Copy link
Member

We don't have the Media Info option implemented in the ItemMenu, so I guess this is something you implemented locally in your branch (hopefully you are interested in contributing it! 🤩). I can't help much without seeing any source, as this is probably an issue in your logic (or a server bug), but to point out where that item is passed to the menu component: https://github.com/jellyfin/jellyfin-vue/blob/master/frontend/src/components/Playback/TrackList.vue#L72

Please, report back

@noaione
Copy link
Contributor Author

noaione commented Apr 13, 2023

so I guess this is something you implemented locally in your branch (hopefully you are interested in contributing it! 🤩)

Yeah, I'm planning to open PR whenever I completed it

I can't help much without seeing any source, as this is probably an issue in your logic (or a server bug)

I think it is intended to be MusicAlbum yeah, I look up jf-web code and they fetch Item information every time you open the context menu so every data is fetched properly.

I tested with adding Copy Stream URL and currently it will not show up in the home screen since it has incomplete data, but it will show up in the item view.

^ EDIT: Can be fixed by adding CanDownload field.

Code here: https://github.com/noaione/jellyfin-vue/tree/feat/more-context-menu (master...noaione:jellyfin-vue:feat/more-context-menu)

@ferferga
Copy link
Member

@noaione Care to explain why do you think it's intended to be that way?

Although the current API is a mess and we can't do major changes to the schema, there have been a lot of minor fixes like this one since the fork. Server can also have bugs, so maybe it's something we can report to them :).

@noaione
Copy link
Contributor Author

noaione commented Apr 13, 2023

Honestly, I don't really know. But I managed to fix the problem at least for this issue.

The item-menu are using a wrong item.

-                  <item-menu v-show="isHovering" :item="item" />
+                  <item-menu v-show="isHovering" :item="track" />

I'll probably add the fix to my whole PR later.

@ferferga
Copy link
Member

@noaione Good catch! Link your PR to this issue so it gets closed after it gets merged please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested waiting for input
Projects
None yet
2 participants