New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Song item detected as MusicAlbum instead of Audio in Context Menu #1950
Comments
We don't have the Media Info option implemented in the ItemMenu, so I guess this is something you implemented locally in your branch (hopefully you are interested in contributing it! 🤩). I can't help much without seeing any source, as this is probably an issue in your logic (or a server bug), but to point out where that item is passed to the menu component: https://github.com/jellyfin/jellyfin-vue/blob/master/frontend/src/components/Playback/TrackList.vue#L72 Please, report back |
Yeah, I'm planning to open PR whenever I completed it
I think it is intended to be I tested with adding ^ EDIT: Can be fixed by adding Code here: https://github.com/noaione/jellyfin-vue/tree/feat/more-context-menu (master...noaione:jellyfin-vue:feat/more-context-menu) |
@noaione Care to explain why do you think it's intended to be that way? Although the current API is a mess and we can't do major changes to the schema, there have been a lot of minor fixes like this one since the fork. Server can also have bugs, so maybe it's something we can report to them :). |
Honestly, I don't really know. But I managed to fix the problem at least for this issue. The - <item-menu v-show="isHovering" :item="item" />
+ <item-menu v-show="isHovering" :item="track" /> I'll probably add the fix to my whole PR later. |
@noaione Good catch! Link your PR to this issue so it gets closed after it gets merged please! |
Description of the bug
If you try to open the item context menu on the Music Album page for the song, it got detected or marked as
MusicAlbum
instead ofAudio
.Steps to reproduce
Expected behavior
The song is marked as
Audio
.Logs
No response
Screenshots
firefox_Em6amXjO9F.mp4
Example of a song in an album marked as
MusicAlbum
instead ofAudio
Jellyfin-web version that are correct.
Platform
Windows
Browser
Firefox
Jellyfin server version
10.8.9
Additional context
Using a modified JF-Vue that are based on 16955dd
The text was updated successfully, but these errors were encountered: