Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing thumbnail on album view for mobile screen size #15

Closed
dkanada opened this issue Jan 11, 2019 · 5 comments
Closed

missing thumbnail on album view for mobile screen size #15

dkanada opened this issue Jan 11, 2019 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dkanada
Copy link
Member

dkanada commented Jan 11, 2019

The android client has always been missing a nice thumbnail on itemdetails for albums similar to movies and shows. I will look into this once I have audio playback functional again.
@dkanada dkanada added bug Something isn't working good first issue Good for newcomers labels Jan 11, 2019
@drago-96
Copy link
Contributor

You mean something like this?
immagine

@dkanada
Copy link
Member Author

dkanada commented Jan 11, 2019

Interesting, this must be a bug only on the android client then, thanks for adding some context. The android client also uses this repository for the UI so I would expect the image to show, but I didn't see any errors at first glance either.

@drago-96
Copy link
Contributor

No wait, this isn't the default behaviour, it's my try to fix it! :D
I was just checking if we were talking about the same thing.

Btw, the same fix could be applied to the artist itemdetail page, which to me didn't show the artist picture.

@dkanada
Copy link
Member Author

dkanada commented Jan 11, 2019

Nice! Definitely apply the fix for the artist detail page if you have time, this issue has bugged me for months!

@dkanada dkanada mentioned this issue Jan 11, 2019
Closed
@drago-96 drago-96 mentioned this issue Jan 11, 2019
Merged
@dkanada dkanada mentioned this issue Jan 22, 2019
Closed
@dkanada
Copy link
Member Author

dkanada commented Jan 27, 2019

closed with #20

@dkanada dkanada closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkanada @drago-96