Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using any Filter in Playlists screen activates all "Features" filters permanently and irreversibly #2744

Closed
deanishe opened this issue Jun 15, 2021 · 7 comments
Labels
bug Something isn't working stale No activity for an extended length of time

Comments

@deanishe
Copy link

deanishe commented Jun 15, 2021

Describe The Bug
Using Filter on the Playlists screen leaves all "Features" filters permanently active/checked, severely breaking Playlists.

Steps To Reproduce

  1. Go to Playlists
  2. Go to Filters
  3. Select Unplayed or a genre (I haven't tried anything else)
  4. Go back to Playlists
  5. All "Features" filters are now active and cannot be deactivated. Unchecking them has no effect. They remain active and will be checked when you re-open the Filters screen.

Expected Behavior
Only filters I select are active and filters I deselect are not active

System (please complete the following information):

  • Platform: Linux (Debian Buster)
  • Browser: Firefox or iOS Jellyfin app
  • Jellyfin Version: 10.7.5-1 from jellyfin-web_10.7.5-1_all.deb

Additional Context
The only way to reset the filters in the iOS app is to delete it and re-install. Deleting the server from the app configuration does not delete the associated settings for some reason.

@deanishe deanishe added the bug Something isn't working label Jun 15, 2021
@deanishe deanishe changed the title Using any Playlist Filter activates all "Features" filters permanently and irreversibly Using any Filter in Playlists screen activates all "Features" filters permanently and irreversibly Jun 15, 2021
@cris01ca
Copy link

cris01ca commented Jul 2, 2021

I'm seeing the same behavior when I'M trying to view one of my movie library. The row at the bottom stays selected and there is no way to unselected them. The same happens on the android app.

opensuse tumbleweed
Chrome 91
Jellyfin Version : 10.7.6

@anthonylavado
Copy link
Member

Myself and the iOS app maintainer aren't seeing this at the moment. I don't have normally have playlists so I created two (one of some music, another of some movies), and I can add filters with no issue. When I come back to the playlists screen, I see the little exclamation mark icon warning me that a filter is in place.

I can navigate out to another screen, come back to playlists, and see that the filter is still present. I can tap on filters again, unselect the filters I applied, and it's back to normal.

Testing on iOS 14.6 with the release version of Jellyfin Mobile, with 10.7.6 running on Debian (Buster).

@deanishe
Copy link
Author

deanishe commented Jul 3, 2021

I checked in the devtools on Firefox (macOS), and the filter keys are all set to null in localStorage. Deleting the filter keys with value null fixes the playlist filtering.

@deanishe
Copy link
Author

deanishe commented Jul 6, 2021

So, I opened Playlists then Filter, selected "Unplayed", then went back to Playlists. Again, all the filters under "Features" were activated and the following entries were added to Local Storage (Firefox 89.0.2 macOS):

image

Deleting all the entries with value null deactivates all the erroneously activated filters.

@lmas
Copy link

lmas commented Jul 7, 2021

Hmm is this block related to this issue?

filters.push('IsResumable');
filters.push('VideoType');
filters.push('HasSubtitles');
filters.push('HasTrailer');
filters.push('HasSpecialFeature');
filters.push('HasThemeSong');
filters.push('HasThemeVideo');

@deanishe
Copy link
Author

I was also affected by the usersettings HTTP 500 bug #2507. After deleting all of Jellyfin's data and settings (which I'd sooner not have to do again…), both that problem and this one have disappeared.

So, it appears that this issue is also related to the user data oopsie causing login and settings to be unavailable to admin users.

Should I close this issue, seeing as it seems to share an underlying cause with others, or leave it open?

@jellyfin-bot
Copy link
Collaborator

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No activity for an extended length of time
Projects
None yet
Development

No branches or pull requests

5 participants