Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware encoding status to playback data #2776

Merged
merged 3 commits into from Aug 24, 2021

Conversation

gnuyent
Copy link
Contributor

@gnuyent gnuyent commented Jul 3, 2021

Hi, this is my first contribution to jellyfin. Let me know if I need to change/fix anything!

Changes
Inside Playback Info, add hardware encoding information.
image
image

Issues

Resolves jellyfin/jellyfin#6087

Connected PR: jellyfin/jellyfin#6258

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YouKnowBlom
Copy link
Contributor

YouKnowBlom commented Jul 25, 2021

Hello, thank you for contributing!:) From my testing it seems like HardwareAccelerationType is not always present in TranscodingInfo. Your first screenshot has the value "none" but I'm not quite sure where that is set?

e: I had not applied the server changes, whoops.

@YouKnowBlom YouKnowBlom self-requested a review July 25, 2021 01:08
@thornbill thornbill added the backend Requires work on the server to finish label Aug 10, 2021
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Aug 24, 2021
@thornbill thornbill merged commit 659da46 into jellyfin:master Aug 24, 2021
Release 10.8.0 automation moved this from Active PRs to Completed PRs Aug 24, 2021
@gnuyent gnuyent deleted the feat/hardware-encode-status branch September 8, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires work on the server to finish
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

Playback data: add info on which encoding (HW or SF) is used
4 participants