Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning instead of error when dictionary has not loaded #2939

Merged
merged 2 commits into from Sep 9, 2021
Merged

Log warning instead of error when dictionary has not loaded #2939

merged 2 commits into from Sep 9, 2021

Conversation

thornbill
Copy link
Member

Changes
This prevents errors for missing translations from being logged on page load when the dictionary has not been loaded yet.

Issues
N/A

dmitrylyzo
dmitrylyzo reviewed Sep 8, 2021
View reviewed changes
src/scripts/globalize.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@thornbill thornbill merged commit 8dd6516 into jellyfin:master Sep 9, 2021
@thornbill thornbill deleted the translation-error-log branch September 9, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thornbill @dmitrylyzo