Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video UI for LiveTV #2952

Merged
merged 1 commit into from Sep 11, 2021
Merged

Fix video UI for LiveTV #2952

merged 1 commit into from Sep 11, 2021

Conversation

dmitrylyzo
Copy link
Contributor

From here we fall to the catch block:

jellyfin-web/src/controllers/playback/video/index.js

Line 185 in 9778f2d

if (currentItem.Chapters.length > 1) {

Changes
Check the Chapters property first.

Issues
Video UI isn't displayed for LiveTV.

P.S.:
We should handle the exception properly (instead of just going home):

jellyfin-web/src/controllers/playback/video/index.js

Lines 1335 to 1337 in 9778f2d

} catch (e) {
appRouter.goHome();
}

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

neilsb
neilsb approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem for me 😄

Have a grey check

@thornbill thornbill merged commit 2abfbba into master Sep 11, 2021
@thornbill thornbill deleted the fix-livetv-video-ui branch September 11, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvium cvium cvium approved these changes

@thornbill thornbill thornbill approved these changes

@neilsb neilsb neilsb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitrylyzo @cvium @thornbill @neilsb