Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header centering on large mobile devices #3017

Merged
merged 1 commit into from Oct 7, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Sep 29, 2021

Changes
Fixes an issue where the header content on the item details page is not centered in the mobile layout on larger devices due to the card width changing.

Screen Shot 2021-09-29 at 16 29 26

This issue was introduced in #2859.

Issues
N/A

@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Sep 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Semi-centered": % is counted from the parent element, and padding is less than the card size.
But it is still better than it was.

@thornbill
Copy link
Member Author

thornbill commented Oct 7, 2021

I noticed it wasn't quite perfect, but definitely an improvement. 😅

@thornbill thornbill merged commit 9a9103a into jellyfin:master Oct 7, 2021
Release 10.8.0 automation moved this from Active PRs to Completed PRs Oct 7, 2021
@thornbill thornbill deleted the fix-tablet-padding branch October 7, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants