New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio player overlapping on small screens #3018
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
c60ad99
to
9c58dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safari 10 seems to handle flexbox in a non-standard way (#3456).
UPD:
Also need to trim these (for remote video):
jellyfin-web/src/components/remotecontrol/remotecontrol.scss
Lines 406 to 414 in eb0479b
.nowPlayingPageImageContainer.nowPlayingPageImagePoster { | |
height: 50%; | |
overflow: hidden; | |
} | |
.nowPlayingPageImageContainer.nowPlayingPageImagePoster img { | |
height: 100%; | |
width: auto; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a poster for cover-less audio.
.nowPlayingPageImageContainerNoAlbum { |
I tried width: 80%
for small media.
UPD:
But the icon looks too big on a small card - need to adjust the font size. In the next PR?
Btw, here is the custom CSS I use for debugging:
.nowPlayingInfoContainer{background-color:rgba(0,255,0,0.5)!important}
.nowPlayingPageImageContainer{background-color:rgba(255,0,0,0.5)!important}
.nowPlayingInfoControls{background-color:rgba(0,0,255,0.5)!important}
.nowPlayingInfoButtons{background-color:rgba(0,255,255,0.5)!important}
.nowPlayingPageImageAudio{opacity:0.5!important}
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Not sure if this is entirely related to outdated Safari client as it is reproducible in chrome desktop. Regardless, I am happy to see a resolution. |
Changes
Fixes the audio player ui on small screens.
This is an alternative to #2972 and #2682 that uses flexbox to size items correctly.
Issues
N/A