Fix JavascriptSubtitlesOctopus dispose #3024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavascriptSubtitlesOctopus
has thedispose
call in the error handler.This makes it hard to control the disposing flow of elements.
Changes
It would be better to remove that
dispose
call. But we need to discuss this with the upstream.Issues
JSO is trying to remove canvas from the video element, but we already removed the latter from the DOM:
https://github.com/jellyfin/JavascriptSubtitlesOctopus/blob/f4625ac313b318bd5d2e0ae18679ff516370bae6/src/subtitles-octopus.js#L863
Steps To Reproduce
bad ASS
subtitles.There is an error with the error message history, but I will fix this in the next PR (just to make things atomic).