Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert UserProfilesPage to react #3025

Merged
merged 3 commits into from Oct 17, 2021
Merged

convert UserProfilesPage to react #3025

merged 3 commits into from Oct 17, 2021

Conversation

grafixeyehero
Copy link
Contributor

No description provided.

@grafixeyehero grafixeyehero mentioned this pull request Oct 2, 2021
Closed
thornbill
thornbill reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to work as expected! I'm not a fan of the component path since we don't really use capitalized directories anywhere else. Maybe we could just use something like components/dashboard/users/SectionTitleButtonElement.tsx?

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 5c8122a into jellyfin:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grafixeyehero @thornbill