Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve show promise #3028

Merged
merged 1 commit into from Oct 4, 2021
Merged

Resolve show promise #3028

merged 1 commit into from Oct 4, 2021

Conversation

dmitrylyzo
Copy link
Contributor

Resolve Promise created by appRouter.show in the ignore block (#2889), as it won't be resolved by the viewshow event.

Changes
Resolve show promise

Issues
Pending Promise in the memory.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@thornbill thornbill merged commit 16b1fb9 into jellyfin:master Oct 4, 2021
@dmitrylyzo dmitrylyzo deleted the resolve-show-promise branch October 4, 2021 17:21
@dmitrylyzo dmitrylyzo mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmitrylyzo @thornbill