Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository url link not opening as external #3044

Merged
merged 1 commit into from Oct 5, 2021

Conversation

thornbill
Copy link
Member

Changes
Fixes repository url links not being treated as external links. This would break web wrapper apps since the link would be opened in the webview instead of calling the NativeShell handler.

Issues
N/A

@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Oct 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 8af91d5 into jellyfin:master Oct 5, 2021
Release 10.8.0 automation moved this from Active PRs to Completed PRs Oct 5, 2021
@thornbill thornbill deleted the fix-repo-url-link branch October 5, 2021 20:46
@blob03
Copy link
Contributor

blob03 commented Oct 6, 2021

I suggest we also add a "cursor:default" style to the enclosing div. This will get rid of the pointer cursor inherited from class 'listItem'
which gives a false sense that everything is clickable.
line 66: html += '<div class="listItem listItem-border" style="cursor:default">';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants