Limit transcoding profiles with maximum resolution

[dmitrylyzo]

Save some CPU cycles and network bandwidth when transcoding 🤞

Changes

• Limit transcoding profiles with maximum resolution
• Limit quality settings with maximum resolution
  ⚠️ If the resolution is in between FHD and UHD, the 4K options are disabled.
  Allow next higher resolution

⚠️ Google Cast needs testing.

Requires jellyfin/jellyfin#7197 and jellyfin/jellyfin#7198

[dmitrylyzo]

The current implementation requires a dependency loop (appHost -> browserDeviceProfile -> appHost) to enable the limit in apps (except TVs) without any modification.

Alternatively, we can post-process the profile: dmitrylyzo@e502200
As a bonus, this will allow to add the limit to a profile that was not generated by browserDeviceProfile.

[thornbill]

@dmitrylyzo Could the max width be passed to the profile builder as an "option"? https://github.com/jellyfin/jellyfin-web/blob/master/src/components/apphost.js#L38-L39

[dmitrylyzo]

@dmitrylyzo Could the max width be passed to the profile builder as an "option"? https://github.com/jellyfin/jellyfin-web/blob/master/src/components/apphost.js#L38-L39

Yes, it is possible (it was my 2nd option), but in this case the resolution limiting will only work in the browser - apps will need to update their getDeviceProfile.

The 3rd option (in the comment above) allows post-processing of any profile, but the app has no options to control that (not a problem to add though).

[thornbill]

👍 I think it's reasonable to expect clients that provide their own profiles to also be responsible for handling the resolution limits. In theory they should be able to determine resolution more accurately anyway.

[dmitrylyzo]

In theory they should be able to determine resolution more accurately anyway.

There is a new AppHost.screen function for this (can be overrided). It is used for the profile and the list of quality options.

As for options, I think we should leave the next higher resolution, i.e. if the screen width greater than 1930 (+10 for sure) add 4K options.

We also need to support portrait oriented videos, but we currently lock the screen in landscape.

[Shadowghost]

Why exactly do we allow the next bigger resolution too? IMHO exactly that should not be done because afaik it leads to Auto choosing 4K when transcoding is required on a local network without bandwith restriction.

[dmitrylyzo]

Why exactly do we allow the next bigger resolution too? IMHO exactly that should not be done because afaik it leads to Auto choosing 4K when transcoding is required on a local network without bandwith restriction.

Quality options don't affect the transcoding resolution limit. The next bigger resolution is for:

If the resolution is in between FHD and UHD, the 4K options are disabled.

For example, you have 2K display, but only 1080p is allowed.

[dmitrylyzo]

Personally, I lean toward the post-processing version:

• to eliminate the dependency loop.
• to re-use the AppHost.screen function instead of duplicating it (and the limiting logic) in apps.
• to add a resolution limit to webui apps "out of the box".
• to fix/trim/post-process the profiles even if they were not generated by browserDeviceProfile.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication