Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playing theme song when using parent links #3444

Merged
merged 1 commit into from Feb 21, 2022

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Feb 20, 2022

A bit hackery - itemShortcuts is more for the items container.

Navigation by plain links breaks the theme song player because there is no BaseItemDto in state.

Changes
Fix playing theme song when using parent links

Issues
N/A

Navigation by plain links breaks the theme song player because
there is no BaseItemDto in 'state'.
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Feb 21, 2022
@thornbill thornbill merged commit e3b8f49 into jellyfin:master Feb 21, 2022
Release 10.8.0 automation moved this from Active PRs to Completed PRs Feb 21, 2022
@dmitrylyzo dmitrylyzo deleted the fix-theme-navigation branch February 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants