Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy buttons to Media Info #3453

Merged
merged 4 commits into from Feb 28, 2022
Merged

Add copy buttons to Media Info #3453

merged 4 commits into from Feb 28, 2022

Conversation

dmitrylyzo
Copy link
Contributor

Changes

  • Extract copy to clipboard function
  • Add copy buttons to Media Info
    Info blocks can be copied individually.
    There is currently no way to copy multiple versions at once.

Issues
Fixes #3075

Screenshots

results in:

test-gray.1080p
Container: mp4
Path: /mnt/hgfs/jellyfin-test/movies/test-gray.1080p.mp4
Size: 2 MB

Video
Title: 1080i H264 SDR
Codec: H264
Codec tag: avc1
AVC: No
Profile: High
Level: 40
Resolution: 1920x1080
Aspect ratio: 16:9
Interlaced: Yes
Framerate: 25
Bitrate: 62 kbps
Bit depth: 8 bit
Video range: SDR
Pixel format: yuv420p
Ref frames: 1
NAL: 0

Subtitle
Title: Английский - ASS
Language: eng
Codec: ASS
Default: No
Forced: No
External: Yes

Subtitle
Title: Русский - SRT
Language: rus
Codec: SRT
Default: No
Forced: No
External: Yes

@dmitrylyzo
Copy link
Contributor Author

dmitrylyzo commented Feb 23, 2022 •
edited

Can't get it pixel perfect to the original (without buttons).
Need to test in Safari. At least clipboard copying doesn't work in Safari 10.

@dmitrylyzo dmitrylyzo force-pushed the mediainfo-copy branch 2 times, most recently from 1863d28 to 6cfb5c4 Compare February 25, 2022 19:10
@dmitrylyzo dmitrylyzo added this to Active PRs in Release 10.8.0 via automation Feb 25, 2022
@dmitrylyzo dmitrylyzo added the needs testing This PR requires additional testing label Feb 25, 2022
@dmitrylyzo dmitrylyzo force-pushed the mediainfo-copy branch 2 times, most recently from 3d8e04f to a27f8be Compare February 25, 2022 22:06
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.4% 1.4% Duplication

Release 10.8.0 automation moved this from Active PRs to Approved PRs Feb 28, 2022
@thornbill thornbill added enhancement Improve existing functionality or small fixes and removed needs testing This PR requires additional testing labels Feb 28, 2022
@thornbill thornbill merged commit a96dff3 into jellyfin:master Feb 28, 2022
Release 10.8.0 automation moved this from Approved PRs to Completed PRs Feb 28, 2022
@dmitrylyzo dmitrylyzo deleted the mediainfo-copy branch February 28, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
No open projects
Release 10.8.0
  
Completed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't Copy Mediainfo
2 participants
@dmitrylyzo @thornbill