Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google cast unsupported message and update translations #3472

Merged
merged 2 commits into from Mar 2, 2022
Merged

Add google cast unsupported message and update translations #3472

merged 2 commits into from Mar 2, 2022

Conversation

thornbill
Copy link
Member

Changes

  • Adds a message in the casting menu when Google Cast is unsupported (chromecast web plugin is not loaded)
  • Updates translation "Cast the media" -> "Cast to Device"
  • Updates translations that use "Chromecast" to use "Google Cast"

Screenshot 2022-02-28 at 12-59-46 Jellyfin

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Feb 28, 2022
@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Feb 28, 2022
@dmitrylyzo
Copy link
Contributor

With a long title:
cast-1

Maybe center it?
cast-2
Now I am not sure 😅

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill
Copy link
Member Author

I adjusted the styles a bit so the title and text are using the same left margin and reduced the space between them... I think it is an improvement. 😅

Release 10.8.0 automation moved this from Active PRs to Approved PRs Mar 2, 2022
@thornbill thornbill merged commit 6f3f15d into jellyfin:master Mar 2, 2022
Release 10.8.0 automation moved this from Approved PRs to Completed PRs Mar 2, 2022
@thornbill thornbill deleted the add-chromecast-unsupported branch March 2, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
No open projects
Release 10.8.0
  
Completed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thornbill @dmitrylyzo