Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check undefined streamInfo.url #3614

Merged
merged 1 commit into from May 5, 2022
Merged

Check undefined streamInfo.url #3614

merged 1 commit into from May 5, 2022

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented May 3, 2022 •
edited

When remuxing and transcoding are disabled and the media cannot be played direct, streamInfo.url is not set.

Don't get here (mediaSource.enableDirectPlay: false):

jellyfin-web/src/components/playback/playbackmanager.js

Lines 2482 to 2483 in 43a0512

if (mediaSource.enableDirectPlay) {
mediaUrl = mediaSource.Path;

Changes
Check undefined streamInfo.url

Issues
Access to undefined streamInfo.url.

jellyfin-web/src/components/playback/playbackmanager.js

Lines 3038 to 3039 in c9e2d11

const currentlyPreventsVideoStreamCopy = streamInfo.url.toLowerCase().indexOf('allowvideostreamcopy=false') !== -1;
const currentlyPreventsAudioStreamCopy = streamInfo.url.toLowerCase().indexOf('allowaudiostreamcopy=false') !== -1;

@dmitrylyzo
fix: Check undefined streamInfo.url
a5163d0 
When remuxing and transcoding are disabled and the media
cannot be played direct, `streamInfo.url` is not set.
@dmitrylyzo dmitrylyzo added the stable backport Backport into the next stable release label May 3, 2022
@dmitrylyzo dmitrylyzo added this to Active PRs in Release 10.8.0 via automation May 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Release 10.8.0 automation moved this from Active PRs to Approved PRs May 5, 2022
@thornbill thornbill added the bug Something isn't working label May 5, 2022
@thornbill thornbill merged commit 76ca940 into jellyfin:release-10.8.z May 5, 2022
Release 10.8.0 automation moved this from Approved PRs to Completed PRs May 5, 2022
jellyfin-bot pushed a commit that referenced this pull request May 21, 2022
@thornbill @crobibero
Merge pull request #3614 from dmitrylyzo/fix-undefined-streaminfo-url
0db3472 
Check undefined streamInfo.url

(cherry picked from commit 76ca940)
Signed-off-by: crobibero <cody@robibe.ro>
@jellyfin-bot jellyfin-bot moved this from Completed PRs to Jellyfinished in Release 10.8.0 May 21, 2022
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 21, 2022
@dmitrylyzo dmitrylyzo deleted the fix-undefined-streaminfo-url branch May 21, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Release 10.8.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitrylyzo @thornbill @jellyfin-bot