Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all theme related color codes to theme .css files #69

Closed
sparky8251 opened this issue Jan 2, 2019 · 2 comments
Closed

Move all theme related color codes to theme .css files #69

sparky8251 opened this issue Jan 2, 2019 · 2 comments
Labels
feature New feature or request

Comments

@sparky8251
Copy link
Contributor

For some reason, several UI colors are stored outside of the theme folders. Not only does this cause color clash, it makes it impossible to make custom themes without building from source.

For examples, see this, this, and this.

You can find these "emby green" spots in the source by searching for 52b54b, 82, 181, 75 (which is the same as the previous hex), 5EC157, 2bc253, and 54f054.

These codes might change if a branding pull is merged.

@sparky8251
Copy link
Contributor Author

Finding additional places that colors are hard coded, like the login page.

@anthonylavado anthonylavado changed the title [UI] [Enhancement] Move all theme related color codes to theme .css files Move all theme related color codes to theme .css files Jan 2, 2019
@anthonylavado anthonylavado transferred this issue from jellyfin/jellyfin Jan 24, 2019
@sparky8251 sparky8251 added enhancement Improve existing functionality or small fixes feature New feature or request and removed enhancement Improve existing functionality or small fixes labels Feb 7, 2019
@jellyfin-bot
Copy link
Collaborator

We are moving all feature and enhancement requests to our new Fider platform here. This new platform lets people vote on and better manage such requests.
This request now lives here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants