Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Display order doesn't handle edge case when metadata source has multiple options for a given type #11274

Open
1 task done
ChildishhAlbino opened this issue Apr 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ChildishhAlbino
Copy link

ChildishhAlbino commented Apr 1, 2024

Please describe your bug

As a user of Jellyfin, when specifying the ordering of episodes for a series as DVD, I cannot specify which particular grouping from TMDB to use as the basis of my series metadata. This results in a mis-ordering of the episodes in my case as TMDB plugin is using the Japanese DVD ordering which is 8 episodes shorter than the English Version.

This results in mislabelled episode titles, descriptions, images - and even bleeds into the next season's worth of episodes after was is the end of the current season in the (incorrectly) applied ordering.

I believe the issue lies in this function where we just find the first item that matches the group type - we are deferring the sorting to whatever is returned by the TMDB API.

References:

TMDB Dbz Kai Episode Groups

Reproduction Steps

  1. Setup a collection that uses TMDB as the only metadata agent for all properties.
  2. Create folder in that collection called Dragon Ball Z Kai and a folder under that called Season 5
  3. Copy any two video files into that subfolder called Dragon Ball Z Kai S05E03 Videl's Crisis! Gohan's Urgent Call-out! and Dragon Ball Z Kai S05E24 Countdown to Revival; Crush Babidi's Ambitions!.mkv
  4. Set the Show metadata to order by DVD
  5. Download fresh metadata for the collection and note the episode titles and descriptions for the two files. They won't match the English ordering. See 3rd attachment

Jellyfin Version

10.8.13

Environment

- OS: Debian 12
- Linux Kernel: 6.1.0-18-amd64
- Virtualization: Docker
- Clients: Browser, Android, Google TV
- Browser: Chrome, Edge, Firefox
- FFmpeg Version:
- Playback Method:
- Hardware Acceleration: QSV
- GPU Model: Intel UHD Graphics 630
- Plugins: TMDB
- Storage: 8TB

Please attach any screenshots here

Show metadata options in Jellyfin
gjthaNnEeD

Available "DVD" episode groups from the TMDB website.
image

Minimum Viable Reproduction done locally
image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ChildishhAlbino ChildishhAlbino added the bug Something isn't working label Apr 1, 2024
@jellyfin-bot
Copy link
Contributor

Hi, it seems like your issue report has the following item(s) that need to be addressed:

  • You have not filled in the environment completely.
  • You have not provided a sufficient amount of logs. Please provide every line during the time of the event plus 10 lines before and after.
  • You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs Testing
Development

No branches or pull requests

2 participants