Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User creation and saving profiles broken for authentication providers #2540

Closed
hukoeth opened this issue Mar 8, 2020 · 9 comments · Fixed by #2712
Closed

User creation and saving profiles broken for authentication providers #2540

hukoeth opened this issue Mar 8, 2020 · 9 comments · Fixed by #2712

Comments

@hukoeth
Copy link

hukoeth commented Mar 8, 2020

I've just installed Jellyfin nightly on my Raspi 4 (armhf, debian package) and found the following issues:

  • When trying to create a new user (setting is enabled in LDAP), error "Login failed" is displayed
  • When saving profiles (in admin dashboard as well as logged in as the user) I also get "Login Failed". Changes are still saved

If you need more information please let me know

@joshuaboniface
Copy link
Member

Confirmed jellyfin/jellyfin-plugin-ldapauth#1 on Debian nightly.

@joshuaboniface
Copy link
Member

From my testing, seems to have been caused by #2363.

@joshuaboniface joshuaboniface changed the title Jellyfin nightly: User creation seems to be broken, Error when saving profiles User creation and saving profiles broken for authentication providers Mar 8, 2020
@joshuaboniface joshuaboniface transferred this issue from jellyfin/jellyfin-plugin-ldapauth Mar 8, 2020
@joshuaboniface
Copy link
Member

Logs when this happens:

Mar 08 15:19:50 jf1.i.net jellyfin[2095]: [15:19:50] [ERR] Error processing request: [10.x.0.y] Invalid user or password entered.

I would expect this to check the auth provider and that create the user, but instead it just dies.

As a test, I'm reverting #2363 to see if this improves things.

@joshuaboniface
Copy link
Member

It's not #2363 but something else. Needs further investigation CC @Bond-009 @dkanada.

@joshuaboniface joshuaboniface added this to To do in Release 10.5.1 Mar 8, 2020
@joshuaboniface
Copy link
Member

For now this isn't really a blocker for 10.5.0 - @hukoeth as a workaround, you could create the user then manually set its authentication provider to the LDAP one in order to auth there.

@dkanada
Copy link
Member

dkanada commented Mar 9, 2020

Hmm I assumed it would be my pull request.

@sauerj
Copy link

sauerj commented Mar 13, 2020

For now this isn't really a blocker for 10.5.0 - @hukoeth as a workaround, you could create the user then manually set its authentication provider to the LDAP one in order to auth there.

I tried this but the login fails with this error:

[2020-03-13 14:44:04.725 +00:00] [ERR] [26] Emby.Server.Implementations.HttpServer.HttpListenerHost: Error processing request
System.NullReferenceException: Object reference not set to an instance of an object.
   at Jellyfin.Plugin.LDAP_Auth.LdapAuthenticationProviderPlugin.Authenticate(String username, String password)
   at Emby.Server.Implementations.Library.UserManager.AuthenticateWithProvider(IAuthenticationProvider provider, String username, String password, User resolvedUser)
   at Emby.Server.Implementations.Library.UserManager.AuthenticateLocalUser(String username, String password, String hashedPassword, User user, String remoteEndPoint)
   at Emby.Server.Implementations.Library.UserManager.AuthenticateUser(String username, String password, String hashedPassword, String remoteEndPoint, Boolean isUserSession)
   at Emby.Server.Implementations.Session.SessionManager.AuthenticateNewSessionInternal(AuthenticationRequest request, Boolean enforcePassword)
   at MediaBrowser.Api.UserService.Post(AuthenticateUserByName request)
   at Emby.Server.Implementations.Services.ServiceExecGeneral.GetTaskResult(Task task)
   at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IRequest httpReq, HttpResponse httpRes, ILogger logger, CancellationToken cancellationToken)
   at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken)

@joshuaboniface
Copy link
Member

Looks like the issue was introduced in #2146 - trying to find the ideal solution.

@Mflixit
Copy link

Mflixit commented Mar 30, 2020

Does anyone have a working Jellyfin + LDAP setup working? Which version of Jellyfin and which version of LDAP plug work together? Thanks. Are there any updates on this issue? Where can I read more about it?

Release 10.5.3 automation moved this from To do to Done Mar 31, 2020
@joshuaboniface joshuaboniface moved this from Done to Jellyfinished in Release 10.5.3 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.5.3
Jellyfinished
Development

Successfully merging a pull request may close this issue.

5 participants